Skip to content

Fix backslashes in stats causing tests to fail on windows #8505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2019
Merged

Fix backslashes in stats causing tests to fail on windows #8505

merged 1 commit into from
Aug 24, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 24, 2019

The chunking test suite hasn't been able to run on windows since #8482 due to unescaped backslashes in the stats file causing an error to be thrown during parsing on windows

@ijjk
Copy link
Member Author

ijjk commented Aug 24, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
buildDuration 23.8s 23.7s -92ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
index.html 3.7 kB 3.7 kB ⚠️ +1 B
index.html gzip 957 B 957 B ✓
link.html 3.74 kB 3.75 kB ⚠️ +1 B
link.html gzip 965 B 964 B -1 B
withRouter.html 3.75 kB 3.75 kB ⚠️ +1 B
withRouter.html gzip 953 B 952 B -1 B
Overall change ⚠️ +3 B

Diffs

Diff for index.html 
@@ -6,9 +6,9 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/index.module.js"
+        <link rel="preload" href="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
@@ -16,9 +16,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/sQWecHPimggqoLs6xfAUqNfF7VE=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/jN57uBy1u6DsoJeQ5czZ8IAbLXk=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/EPCh-GEqGkXjlRneO9wla/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,18 +26,18 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"EPCh-GEqGkXjlRneO9wla"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"Sx8uCYJ5VmH5AwcIuoDJc"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -51,15 +51,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/wTGea4u+GSc5doSf1NqSKiUBclo=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/qWLWwEVMZZz9QQOAxTNwBqoIv+U=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/sQWecHPimggqoLs6xfAUqNfF7VE=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/jN57uBy1u6DsoJeQ5czZ8IAbLXk=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/sQWecHPimggqoLs6xfAUqNfF7VE=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/jN57uBy1u6DsoJeQ5czZ8IAbLXk=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/EPCh-GEqGkXjlRneO9wla/_buildManifest.js"
+        <script src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/EPCh-GEqGkXjlRneO9wla/_buildManifest.module.js"
+        <script src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for link.html 
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/link.module.js"
+        <link rel="preload" href="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/sQWecHPimggqoLs6xfAUqNfF7VE=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/jN57uBy1u6DsoJeQ5czZ8IAbLXk=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/EPCh-GEqGkXjlRneO9wla/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"EPCh-GEqGkXjlRneO9wla"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"Sx8uCYJ5VmH5AwcIuoDJc"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/wTGea4u+GSc5doSf1NqSKiUBclo=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/qWLWwEVMZZz9QQOAxTNwBqoIv+U=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/sQWecHPimggqoLs6xfAUqNfF7VE=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/jN57uBy1u6DsoJeQ5czZ8IAbLXk=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/sQWecHPimggqoLs6xfAUqNfF7VE=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/jN57uBy1u6DsoJeQ5czZ8IAbLXk=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/EPCh-GEqGkXjlRneO9wla/_buildManifest.js"
+        <script src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/EPCh-GEqGkXjlRneO9wla/_buildManifest.module.js"
+        <script src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for withRouter.html 
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/sQWecHPimggqoLs6xfAUqNfF7VE=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/jN57uBy1u6DsoJeQ5czZ8IAbLXk=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/EPCh-GEqGkXjlRneO9wla/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"EPCh-GEqGkXjlRneO9wla"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"Sx8uCYJ5VmH5AwcIuoDJc"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/EPCh-GEqGkXjlRneO9wla/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/wTGea4u+GSc5doSf1NqSKiUBclo=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/qWLWwEVMZZz9QQOAxTNwBqoIv+U=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/sQWecHPimggqoLs6xfAUqNfF7VE=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/jN57uBy1u6DsoJeQ5czZ8IAbLXk=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/sQWecHPimggqoLs6xfAUqNfF7VE=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/jN57uBy1u6DsoJeQ5czZ8IAbLXk=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/EPCh-GEqGkXjlRneO9wla/_buildManifest.js"
+        <script src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/EPCh-GEqGkXjlRneO9wla/_buildManifest.module.js"
+        <script src="/_next/static/Sx8uCYJ5VmH5AwcIuoDJc/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
buildDuration 25.7s 25.8s ⚠️ +42ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix-chunking-test-windows Change
_error.js 247 kB 247 kB ⚠️ +3 B
_error.js gzip 66.5 kB 66.4 kB -33 B
hooks.html 3.81 kB 3.81 kB ⚠️ +2 B
hooks.html gzip 979 B 981 B ⚠️ +2 B
index.js 248 kB 248 kB ⚠️ +3 B
index.js gzip 66.7 kB 66.5 kB -195 B
link.js 255 kB 255 kB ⚠️ +3 B
link.js gzip 68.8 kB 68.8 kB ⚠️ +44 B
routerDirect.js 249 kB 249 kB ⚠️ +3 B
routerDirect.js gzip 66.7 kB 66.7 kB -2 B
withRouter.js 248 kB 248 kB ⚠️ +3 B
withRouter.js gzip 66.7 kB 66.7 kB -1 B
Overall change ⚠️ +17 B

@Timer Timer merged commit 5e4d7f2 into vercel:canary Aug 24, 2019
@ijjk ijjk deleted the fix-chunking-test-windows branch August 27, 2019 16:37
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @Timer