Skip to content

fix(next/image): add ?dpl query string for local images (without static import) #86485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from
Open

fix(next/image): add ?dpl query string for local images (without static import) #86485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f795759
fix(next/image): add `?dpl` query string for local images (without im…
styfle Nov 24, 2025
1d1b353
Merge branch 'canary' into styfle/fix-dpl-query-microfrontend
styfle Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/src/shared/lib/image-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ function defaultLoader({
const q = findClosestQuality(quality, config)

return `${config.path}?url=${encodeURIComponent(src)}&w=${width}&q=${q}${
src.startsWith('/_next/static/media/') && process.env.NEXT_DEPLOYMENT_ID
src.startsWith('/') && process.env.NEXT_DEPLOYMENT_ID
? `&dpl=${process.env.NEXT_DEPLOYMENT_ID}`
: ''
}`
Expand Down
36 changes: 33 additions & 3 deletions test/unit/next-image-get-img-props.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,37 @@ describe('getImageProps()', () => {
delete process.env.NEXT_DEPLOYMENT_ID
}
})
it('should not add query string for relative local image when NEXT_DEPLOYMENT_ID defined', async () => {
it('should add query string for imported local image from microfrontend when NEXT_DEPLOYMENT_ID defined', async () => {
try {
process.env.NEXT_DEPLOYMENT_ID = 'dpl_123'
const { props } = getImageProps({
alt: 'a nice desc',
src: '/microfrontend/_next/static/media/test.abc123.png', // simulating microfrontend path
width: 100,
height: 200,
})
expect(warningMessages).toStrictEqual([])
expect(Object.entries(props)).toStrictEqual([
['alt', 'a nice desc'],
['loading', 'lazy'],
['width', 100],
['height', 200],
['decoding', 'async'],
['style', { color: 'transparent' }],
[
'srcSet',
'/_next/image?url=%2Fmicrofrontend%2F_next%2Fstatic%2Fmedia%2Ftest.abc123.png&w=128&q=75&dpl=dpl_123 1x, /_next/image?url=%2Fmicrofrontend%2F_next%2Fstatic%2Fmedia%2Ftest.abc123.png&w=256&q=75&dpl=dpl_123 2x',
],
[
'src',
'/_next/image?url=%2Fmicrofrontend%2F_next%2Fstatic%2Fmedia%2Ftest.abc123.png&w=256&q=75&dpl=dpl_123',
],
])
} finally {
delete process.env.NEXT_DEPLOYMENT_ID
}
})
it('should add query string for relative local image when NEXT_DEPLOYMENT_ID defined', async () => {
try {
process.env.NEXT_DEPLOYMENT_ID = 'dpl_123'
const { props } = getImageProps({
Expand All @@ -659,9 +689,9 @@ describe('getImageProps()', () => {
['style', { color: 'transparent' }],
[
'srcSet',
'/_next/image?url=%2Ftest.png&w=128&q=75 1x, /_next/image?url=%2Ftest.png&w=256&q=75 2x',
'/_next/image?url=%2Ftest.png&w=128&q=75&dpl=dpl_123 1x, /_next/image?url=%2Ftest.png&w=256&q=75&dpl=dpl_123 2x',
],
['src', '/_next/image?url=%2Ftest.png&w=256&q=75'],
['src', '/_next/image?url=%2Ftest.png&w=256&q=75&dpl=dpl_123'],
])
} finally {
delete process.env.NEXT_DEPLOYMENT_ID
Expand Down
Loading