Extract web UI API client and trace viewer into shared package #125
Conversation
🦋 Changeset detectedLatest commit: 28a5603 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| join(nitro.options.rootDir, 'workflows'), | ||
| ...nitro.options.scanDirs.map((dir) => join(dir, 'workflows')), | ||
| ].map((dir) => resolve(nitro.options.rootDir, dir))).sort(); | ||
| return unique( |
There was a problem hiding this comment.
is this just a formatting change?
There was a problem hiding this comment.
yes - must have originally not been formatted with biome
| @@ -0,0 +1,59 @@ | |||
| { | |||
There was a problem hiding this comment.
Can you also symlink the LICENSE from the repo root please like we do in all the other packages?
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔧 Build Fix:
The TypeScript compiler fails because the imported hydrateWorkflowArguments function from '@workflow/core/serialization' is never used in the file.
View Details
📝 Patch Details
diff --git a/packages/web-shared/src/api/workflow-server-actions.ts b/packages/web-shared/src/api/workflow-server-actions.ts
index ffe549e..2ad7ade 100644
--- a/packages/web-shared/src/api/workflow-server-actions.ts
+++ b/packages/web-shared/src/api/workflow-server-actions.ts
@@ -2,7 +2,7 @@
import { hydrateResourceIO } from '@workflow/core/observability';
import { createWorld, start } from '@workflow/core/runtime';
-import { hydrateWorkflowArguments } from '@workflow/core/serialization';
+
import type {
Event,
Hook,
Analysis
Unused import causes TypeScript compilation failure
What fails: TypeScript compiler fails on packages/web-shared/src/api/workflow-server-actions.ts due to unused import hydrateWorkflowArguments
How to reproduce:
cd packages/web-shared && pnpm run buildResult:
src/api/workflow-server-actions.ts(5,1): error TS6133: 'hydrateWorkflowArguments' is declared but its value is never read.
There was a problem hiding this comment.
🔧 Build Fix:
The hydrateWorkflowArguments import is declared but never used in the file, causing TypeScript compilation to fail with error TS6133.
View Details
📝 Patch Details
diff --git a/packages/web-shared/src/api/workflow-server-actions.ts b/packages/web-shared/src/api/workflow-server-actions.ts
index ffe549e..2ad7ade 100644
--- a/packages/web-shared/src/api/workflow-server-actions.ts
+++ b/packages/web-shared/src/api/workflow-server-actions.ts
@@ -2,7 +2,7 @@
import { hydrateResourceIO } from '@workflow/core/observability';
import { createWorld, start } from '@workflow/core/runtime';
-import { hydrateWorkflowArguments } from '@workflow/core/serialization';
+
import type {
Event,
Hook,
Analysis
Unused import causes TypeScript compilation failure
What fails: TypeScript compiler fails on packages/web-shared/src/api/workflow-server-actions.ts due to unused import hydrateWorkflowArguments
How to reproduce:
cd packages/web-shared && pnpm run buildResult:
src/api/workflow-server-actions.ts(5,1): error TS6133: 'hydrateWorkflowArguments' is declared but its value is never read.
There was a problem hiding this comment.
🔧 Build Fix:
The file imports hydrateWorkflowArguments from @workflow/core/serialization but never uses it, causing a TypeScript compilation error TS6133.
View Details
📝 Patch Details
diff --git a/packages/web-shared/src/api/workflow-server-actions.ts b/packages/web-shared/src/api/workflow-server-actions.ts
index ffe549e..40e0752 100644
--- a/packages/web-shared/src/api/workflow-server-actions.ts
+++ b/packages/web-shared/src/api/workflow-server-actions.ts
@@ -2,7 +2,6 @@
import { hydrateResourceIO } from '@workflow/core/observability';
import { createWorld, start } from '@workflow/core/runtime';
-import { hydrateWorkflowArguments } from '@workflow/core/serialization';
import type {
Event,
Hook,
Analysis
TypeScript unused import causes build failure
What fails: TypeScript compiler fails on packages/web-shared/src/api/workflow-server-actions.ts due to unused import hydrateWorkflowArguments
How to reproduce:
cd packages/web-shared && pnpm run buildResult:
src/api/workflow-server-actions.ts(5,1): error TS6133: 'hydrateWorkflowArguments' is declared but its value is never read.
ELIFECYCLE Command failed with exit code 2.
There was a problem hiding this comment.
🔧 Build Fix:
The hydrateWorkflowArguments import is declared but never used in the file, causing a TypeScript compilation error.
View Details
📝 Patch Details
diff --git a/packages/web-shared/src/api/workflow-server-actions.ts b/packages/web-shared/src/api/workflow-server-actions.ts
index ffe549e..40e0752 100644
--- a/packages/web-shared/src/api/workflow-server-actions.ts
+++ b/packages/web-shared/src/api/workflow-server-actions.ts
@@ -2,7 +2,6 @@
import { hydrateResourceIO } from '@workflow/core/observability';
import { createWorld, start } from '@workflow/core/runtime';
-import { hydrateWorkflowArguments } from '@workflow/core/serialization';
import type {
Event,
Hook,
Analysis
Unused import causes TypeScript compilation failure
What fails: TypeScript compiler fails on packages/web-shared/src/api/workflow-server-actions.ts due to unused import hydrateWorkflowArguments
How to reproduce:
cd packages/web-shared && pnpm run buildResult:
src/api/workflow-server-actions.ts(5,1): error TS6133: 'hydrateWorkflowArguments' is declared but its value is never read.
There was a problem hiding this comment.
🔧 Build Fix:
The TypeScript build fails because hydrateWorkflowArguments is imported but never used in the file, triggering error TS6133 due to the strict noUnusedLocals compiler setting.
View Details
📝 Patch Details
diff --git a/packages/web-shared/src/api/workflow-server-actions.ts b/packages/web-shared/src/api/workflow-server-actions.ts
index ffe549e..2ad7ade 100644
--- a/packages/web-shared/src/api/workflow-server-actions.ts
+++ b/packages/web-shared/src/api/workflow-server-actions.ts
@@ -2,7 +2,7 @@
import { hydrateResourceIO } from '@workflow/core/observability';
import { createWorld, start } from '@workflow/core/runtime';
-import { hydrateWorkflowArguments } from '@workflow/core/serialization';
+
import type {
Event,
Hook,
Analysis
Unused import causes TypeScript compilation failure
What fails: TypeScript compiler fails on packages/web-shared/src/api/workflow-server-actions.ts due to unused import hydrateWorkflowArguments
How to reproduce:
pnpm turbo run build --filter=@workflow/web-sharedResult:
src/api/workflow-server-actions.ts(5,1): error TS6133: 'hydrateWorkflowArguments' is declared but its value is never read.
Addresses #30 by extracting re-usable NextJS code for any o11y deployment.
See slack thread for context.