Skip to content

feat: move NextBuilder to @workflow/next package #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

feat: move NextBuilder to @workflow/next package #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/move-next-builder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@workflow/next": patch
---

Move NextBuilder to @workflow/next package
2 changes: 0 additions & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
},
"devDependencies": {
"@types/node": "catalog:",
"@types/watchpack": "2.4.4",
"@workflow/tsconfig": "workspace:*"
},
"dependencies": {
Expand Down Expand Up @@ -68,7 +67,6 @@
"ora": "^8.2.0",
"terminal-link": "^5.0.0",
"tinyglobby": "^0.2.14",
"watchpack": "2.4.4",
"xdg-app-paths": "^5.1.0",
"zod": "catalog:"
}
Expand Down
2 changes: 1 addition & 1 deletion ...li/src/lib/builders/webhook-route.test.ts → ...rc/lib/builders/webhook-route.test.ts.bkp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { mkdir, readFile, rm } from 'node:fs/promises';
import { join } from 'node:path';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
import type { WorkflowConfig } from '../config/types.js';
import { NextBuilder } from './next-build.js';
import { NextBuilder } from '@workflow/next/builder';
Copy link
Collaborator Author

@pranaygp pranaygp Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test doesn't have a good place to live right now because of the migration. I'm just disabling it for now by changing it to .bkp and will bring it back in the top of the PR stack once everything is done migrating

import { VercelBuildOutputAPIBuilder } from './vercel-build-output-api.js';

describe('Webhook route generation', () => {
Expand Down
6 changes: 4 additions & 2 deletions packages/next/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,17 @@
},
"dependencies": {
"@swc/core": "1.11.24",
"@workflow/cli": "workspace:*",
"@workflow/builders": "workspace:*",
"@workflow/core": "workspace:*",
"@workflow/swc-plugin": "workspace:*",
"semver": "7.7.3"
"semver": "7.7.3",
"watchpack": "2.4.4"
},
"devDependencies": {
"@workflow/tsconfig": "workspace:*",
"@types/node": "catalog:",
"@types/semver": "7.7.1",
"@types/watchpack": "2.4.4",
"next": "16.0.1"
},
"peerDependencies": {
Expand Down
0 packages/cli/src/lib/builders/next-build.ts → packages/next/src/builder.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/next/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { NextBuilder } from '@workflow/cli/dist/lib/builders/next-build';
import { NextBuilder } from './builder.js';
import type { NextConfig } from 'next';
import semver from 'semver';

Expand Down
2 changes: 1 addition & 1 deletion packages/next/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// re-export runtime as stub for resolving to not
// require @workflow/core be a dependency as well as
// @workflow/next
export * from '@workflow/cli/dist/lib/runtime';
export * from '@workflow/core/dist/runtime';
16 changes: 8 additions & 8 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.