Skip to content

Add interposer wires #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 60 commits into from
Oct 29, 2025
Merged

Add interposer wires #3305

merged 60 commits into from
Oct 29, 2025

Conversation

@soheilshahrouz
Copy link
Contributor

@soheilshahrouz soheilshahrouz commented Oct 14, 2025 •
edited
Loading

This PR adds support for inter-die wires defined using the <interdie_wire> tag under <interposer_cut> in the architecture file. The graphics code has been updated accordingly to visualize these wires correctly.

@soheilshahrouz
Merge remote-tracking branch 'origin/interposer_parsing' into temp_ad…
6596c75 
…d_interposer_wires
@soheilshahrouz
add convert_interposer_cuts_to_sg_patterns()
c694846
@soheilshahrouz
replace x_spec/y_spec with a t_specified_loc member var
1c6a086
@soheilshahrouz
pass scatter-gather's specified loc to sb_not_here()
4376303
@soheilshahrouz
Merge branch 'temp_3d_sg' into temp_add_interposer_wires
5308b87
@soheilshahrouz
Merge remote-tracking branch 'origin/interposer_parsing' into temp_ad…
0aca585 
…d_interposer_wires
@soheilshahrouz
add cut locs to DeviceGrid
9d705d9
@soheilshahrouz
call convert_interposer_cuts_to_sg_patterns() in RR graph generation
f0b8ffd
@soheilshahrouz
get rid of compilation errors in tests
2f0bfb0
@soheilshahrouz
pass the copied version of sg_patterns to alloc_and_load_scatter_gath…
3482540 
…er_connections
@soheilshahrouz
add alloc_and_load_non_3d_sg_pattern_rr_node_indices()
b5a8ec2
@soheilshahrouz
remove is_flat from arguments of alloc_and_load_rr_graph()
b47ec96
@soheilshahrouz
add add_and_connect_non_3d_sg_links()
d585890
@soheilshahrouz
Merge branch 'temp_3d_sg' into temp_add_interposer_wires
e7a88eb
@soheilshahrouz
call add_and_connect_non_3d_sg_links()
d55fbd9
@soheilshahrouz
Merge branch 'temp_3d_sg' into temp_add_interposer_wires
899c855
@soheilshahrouz
renamed shadowing vars
1a503e1
@soheilshahrouz
bugfix: cur_loc was added twice to offest
be6af33
@soheilshahrouz
updated architecture file
99b6b43
@soheilshahrouz
compute chan width from RR graph and store in global context
c923574
@soheilshahrouz
fix commenting style in init_draw_coords()
0d66efc
@soheilshahrouz
bugfix: update drawing when update_screen() is called instead
1294079
@soheilshahrouz
use chand widtd extracted from rr graph to specify how far blocks sho…
db99b4c 
…uld be far from each other
@soheilshahrouz
initialize cost index for interposer wires
5d8045b
@soheilshahrouz
Merge branch 'temp_draw_edges_cleanup' into temp_add_interposer_wires
ccf70b1
@soheilshahrouz
avoid repetitive computation in draw_get_rr_chan_bbox()
a762189
@soheilshahrouz
draw U-turn connections in SB for CHANY DEC->INC
6adced3
@soheilshahrouz
draw nodes on top of edges
9ace63f
@soheilshahrouz
Merge branch 'temp_interposer_cut_dim' into temp_add_interposer_wires
491a72b
@soheilshahrouz
clean drawplace()
5a94c8b
@soheilshahrouz soheilshahrouz changed the title [WIP] Add interposer wires Add interposer wires Oct 16, 2025
@AmirhosseinPoolad
Copy link
Contributor

Soheil changed the --device behaviour to be more aligned with the documentation in this PR. While the docs say that if --device is not set, the auto sized device would be selected, previously it would select some fixed size device if there was no auto sized device defined in the architecture file. Now it errors out if --device is not set and there's no auto sized device. This is the reason for the current strong test failure.

AmirhosseinPoolad
AmirhosseinPoolad reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed until (but not including) draw_rr_edges.cpp so far.

vaughnbetz
vaughnbetz requested changes Oct 17, 2025
View reviewed changes
AmirhosseinPoolad
AmirhosseinPoolad reviewed Oct 21, 2025
View reviewed changes
Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the rest of the files. Very minor comments overall.

@soheilshahrouz
Copy link
Contributor Author

@vaughnbetz I can't merge this PR myself. If you don't have further comments, can you merge it?

vaughnbetz
vaughnbetz approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vaughnbetz vaughnbetz merged commit 759e7aa into master Oct 29, 2025
30 checks passed
@vaughnbetz vaughnbetz deleted the temp_add_interposer_wires branch October 29, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmirhosseinPoolad AmirhosseinPoolad AmirhosseinPoolad left review comments

@vaughnbetz vaughnbetz vaughnbetz approved these changes

Assignees

No one assigned

Labels

docs Documentation lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions libvtrutil VPR VPR FPGA Placement & Routing Tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soheilshahrouz @AmirhosseinPoolad @vaughnbetz