Reapply "Feature ap draw" #3311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9b16536.
github-actions
bot
added
VPR
|
Yep, the failure we are seeing here is the same failure I was seeing when we merged into CI. It looks like a auto-conflict resolution which removed some important code. |
|
I am happy that was the issue! Thanks @robluo. It looks like one commit removed the DeviceGrid variable from the function, which conflicted with your code in a way that Git did not expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9b16536.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: