[core] fix: stop fabricating rollout log probabilities#92
Merged
wuxibin89 merged 1 commit intoJul 24, 2026
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
wuxibin89
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stop emitting fabricated zero rollout log probabilities when a trajectory does not provide them. VERL uses the presence of
rollout_log_probsto enable rollout-logprob paths, so synthetic zeros can silently contaminate bypass or off-policy importance-sampling behavior.This PR also removes the dead gateway-level
base_sampling_paramsconfig layer. Session sampling parameters are already the runtime source of defaults, and merging an always-empty base dictionary is a no-op.Checklist Before Starting
[core] fix: stop fabricating rollout log probabilities.Test
No recipe rollout was run; this focused core change is covered by the affected CPU unit tests.
API and Usage Example
GatewayActorConfig.base_sampling_paramsis removed. Put sampling defaults on each session instead:Design & Code Changes
rollout_log_probsonly whentrajectory.response_logprobsis present, matching the adjacent conditionalrouted_expertsemission pattern.GatewayActorConfig.base_sampling_paramsand_GatewayActor._base_sampling_params.session.sampling_paramsdirectly to the OpenAI and Anthropic adapters; their existingbase_sampling_paramsargument names remain unchanged.create_session(..., sampling_params=...).Checklist Before Submitting
pre-commit run --all-files --show-diff-on-failure --color=always.