[WIP][examples] fix: use shell to run cmd in sandbox#93
Open
ShengDev wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
ShengDev
force-pushed
the
fix/command-output
branch
from
July 24, 2026 03:34
e96bb34 to
c93d7e0
Compare
Signed-off-by: sheng <sheng.gao.dev@gmail.com>
ShengDev
force-pushed
the
fix/command-output
branch
from
July 24, 2026 03:38
c93d7e0 to
48893d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
During reward calculation, multiple commands are executed. The set -x option is used to echo each executed command to the output; however, by default, these traces are written to stderr. This results in execution outputs being split across stdout and stderr. To ensure correct parsing, all outputs — both command traces and their results — should be merged sequentially as expected.
This PR utilizes shell.run() over command.run() to execute commands in the openYuanrong sandbox, ensuring outputs are returned both sequentially and atomically.
Checklist Before Starting
[{modules}] {type}: {description}(checked by CI){modules}may includecore,interaction,model,env,tools,deployment,reward,dashboard,docs,examples,data,train,ci,build,deps,misc,like[interaction, tools, docs]{type}must be one offeat,fix,refactor,chore,test[BREAKING]to the beginning of the title[1/N][BREAKING][deployment, docs] feat: simplify runtime env configurationTest
manuel test is done in remote sandbox system
API and Usage Example
This PR does not change API. It changes the implemention of command execution
Design & Code Changes
This PR utilizes shell.run() over command.run() to execute commands in the openYuanrong sandbox, ensuring outputs are returned both sequentially and atomically.
examples/blackbox_recipes/claude_code/claude_code_runner.py
async def run utilizes shell.run() over command.run()
Checklist Before Submitting
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always