[core] feat: support multiple veFaaS functions and fix KillSandbox hang#94
Merged
yyDing1 merged 1 commit intoJul 26, 2026
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
xuefei199288
force-pushed
the
feat/vefaas-multi-function-and-killsandbox-fix
branch
2 times, most recently
from
July 25, 2026 09:59
82eae3e to
78eeb48
Compare
Allow VEFAAS_FUNCTION_ID / VEFAAS_FUNCTION_ROUTE to each hold a comma-separated list of paired values; each sandbox binds to one randomly chosen (function_id, function_route) pair for its lifetime, spreading load across functions with no shared state. _get_vefaas_client also accepts explicit credentials so callers can build their own client pool. Also switch the sandbox start command from `curl ... | bash` to a download-then-`exec bash` form: with a pipe the install script's shell is never PID 1, so its SIGTERM trap can't fire on KillSandbox and the sandbox hangs in Terminating until the grace window expires. `exec` makes the script shell PID 1 so it receives SIGTERM directly and cleans up. Includes docs and unit tests for pairing, random selection, and env validation.
xuefei199288
force-pushed
the
feat/vefaas-multi-function-and-killsandbox-fix
branch
from
July 25, 2026 09:59
78eeb48 to
dc394a0
Compare
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VEFAAS_FUNCTION_ID/VEFAAS_FUNCTION_ROUTEto each hold a comma-separated list of paired values. Each sandbox binds to one randomly chosen(function_id, function_route)pair for its lifetime, spreading load across functions with no shared/coordinated state.is_vefaas_rate_limited/is_vefaas_not_found(429 / 404) error classifiers, and let_get_vefaas_clientaccept explicit credentials so external drivers can build their own client pool.Terminating: switch the sandbox start command fromcurl ... | bashto a download-then-exec bashform. With a pipe, the install script's shell is never PID 1, so its SIGTERM trap can't fire on KillSandbox and the sandbox hangs until the grace window expires.execmakes the script shell PID 1 so it receives SIGTERM directly and cleans up.Test plan
tests/uni_agent/sandbox/test_exec_error_policy.py).docs/source/quickstart/launch-sandbox.md).exec bashstart command.