bugfix: avoid nil and add unit tests

internal/config/config.go

@@ -35,8 +35,7 @@ var (
 	}
 )
 
-func NewConfig(path string) (*Config, error) {
-	p := filepath.Join(path, filename)
+func NewConfigWithPath(p string) (*Config, error) {
 	if !util.FileExists(p) {
 		content, err := yaml.Marshal(defaultConfig)
 		if err != nil {
@@ -53,5 +52,14 @@ func NewConfig(path string) (*Config, error) {
 	if err != nil {
 		return nil, err
 	}
+	if config.Proxy == nil {
+		config.Proxy = EmptyProxy
+	}
 	return config, nil
+
+}
+
+func NewConfig(path string) (*Config, error) {
+	p := filepath.Join(path, filename)
+	return NewConfigWithPath(p)
 }

internal/config/config.yaml

@@ -1,3 +1,6 @@
 proxy:
   enable: false
-  url: http://test
+  url: http://test
+
+storage:
+  path: /tmp

internal/config/config_test.go

@@ -40,3 +40,15 @@ func TestConfig_Proxy(t *testing.T) {
 		t.Fatal("proxy enable is invalid")
 	}
 }
+func TestConfigWithEmptyProxy(t *testing.T) {
+	c, err := config.NewConfigWithPath("empty_test.yaml")
+	if err != nil {
+		t.Fatal(err)
+	}
+	if c.Proxy.Url != "" {
+		t.Fatal("proxy url must be empty")
+	}
+	if !c.Proxy.Enable == false {
+		t.Fatal("proxy enable must be false")
+	}
+}