mod: Use the plugin name as the installed sdk name

Previously the plugin's filename was used as the sdk name.

internal/sdk/manager.go

@@ -196,7 +196,6 @@ func (m *Manager) Update(pluginName string) error {
 }
 
 func (m *Manager) Add(pluginName, url, alias string) error {
-	pname := pluginName
 	// official plugin
 	if len(url) == 0 {
 		args := strings.Split(pluginName, "/")
@@ -205,7 +204,6 @@ func (m *Manager) Add(pluginName, url, alias string) error {
 		}
 		category := args[0]
 		name := args[1]
-		pname = category
 		availablePlugins, err := m.Available()
 		if err != nil {
 			return err
@@ -222,16 +220,7 @@ func (m *Manager) Add(pluginName, url, alias string) error {
 		}
 	}
 
-	if len(alias) > 0 {
-		pname = alias
-	}
-
-	destPath := filepath.Join(m.PathMeta.PluginPath, pname+".lua")
-	if util.FileExists(destPath) {
-		return fmt.Errorf("plugin %s already exists", pname)
-	}
-
-	pterm.Printf("Adding plugin from %s...\n", url)
+	pterm.Printf("Loading plugin from %s...\n", url)
 	content, err := m.loadLuaFromFileOrUrl(url)
 	if err != nil {
 		return fmt.Errorf("failed to load plugin: %w", err)
@@ -242,6 +231,15 @@ func (m *Manager) Add(pluginName, url, alias string) error {
 		return fmt.Errorf("check plugin error: %w", err)
 	}
 	defer source.Close()
+
+	pname := source.Name
+	if len(alias) > 0 {
+		pname = alias
+	}
+	destPath := filepath.Join(m.PathMeta.PluginPath, pname+".lua")
+	if util.FileExists(destPath) {
+		return fmt.Errorf("plugin %s already exists", pname)
+	}
 	err = os.WriteFile(destPath, []byte(content), 0644)
 	if err != nil {
 		return fmt.Errorf("add plugin error: %w", err)

internal/sdk/plugin.go

@@ -22,8 +22,7 @@ import (
 	"github.com/version-fox/vfox/internal/module"
 	"github.com/version-fox/vfox/internal/util"
 	lua "github.com/yuin/gopher-lua"
-	"path/filepath"
-	"strings"
+	"regexp"
 )
 
 const (
@@ -38,7 +37,6 @@ type LuaPlugin struct {
 	pluginObj *lua.LTable
 	// plugin source path
 	SourcePath  string
-	SourceName  string
 	Name        string
 	Author      string
 	Version     string
@@ -342,15 +340,19 @@ func NewLuaPlugin(content, path string, osType util.OSType, archType util.ArchTy
 		state:      luaVMInstance,
 		pluginObj:  PLUGIN,
 		SourcePath: path,
-		SourceName: strings.TrimSuffix(filepath.Base(path), filepath.Ext(path)),
 	}
 
 	if err := source.checkValid(); err != nil {
 		return nil, err
 	}
 
-	if name := PLUGIN.RawGetString("name"); name.Type() != lua.LTNil {
+	if name := PLUGIN.RawGetString("name"); name.Type() == lua.LTNil {
+		return nil, fmt.Errorf("no plugin name provided")
+	} else {
 		source.Name = name.String()
+		if !isValidName(source.Name) {
+			return nil, fmt.Errorf("invalid plugin name")
+		}
 	}
 	if version := PLUGIN.RawGetString("version"); version.Type() != lua.LTNil {
 		source.Version = version.String()
@@ -366,3 +368,10 @@ func NewLuaPlugin(content, path string, osType util.OSType, archType util.ArchTy
 	}
 	return source, nil
 }
+
+func isValidName(name string) bool {
+	// The regular expression means: start with a letter,
+	// followed by any number of letters, digits, or underscores.
+	re := regexp.MustCompile(`^[a-zA-Z][a-zA-Z0-9_]*$`)
+	return re.MatchString(name)
+}

internal/sdk/sdk.go

@@ -208,7 +208,7 @@ func (b *Sdk) Use(version Version, scope UseScope) error {
 			return err
 		}
 	}
-	b.sdkManager.Record.Add(b.Plugin.SourceName, string(version))
+	b.sdkManager.Record.Add(b.Plugin.Name, string(version))
 	defer b.sdkManager.Record.Save()
 	pterm.Printf("Now using %s.\n", pterm.LightGreen(label))
 	if !env.IsHookEnv() {
@@ -238,7 +238,7 @@ func (b *Sdk) List() []Version {
 }
 
 func (b *Sdk) Current() Version {
-	version := b.sdkManager.Record.Export()[b.Plugin.SourceName]
+	version := b.sdkManager.Record.Export()[b.Plugin.Name]
 	return Version(version)
 }
 
@@ -394,7 +394,7 @@ func (b *Sdk) label(version Version) string {
 func NewSdk(manager *Manager, source *LuaPlugin) (*Sdk, error) {
 	return &Sdk{
 		sdkManager:  manager,
-		InstallPath: filepath.Join(manager.PathMeta.SdkCachePath, strings.ToLower(source.SourceName)),
+		InstallPath: filepath.Join(manager.PathMeta.SdkCachePath, strings.ToLower(source.Name)),
 		Plugin:      source,
 	}, nil
 }