Read-only and read-write Database and Transaction#49
Open
cmbrandenburg wants to merge 1 commit intovhbit:masterfrom
cmbrandenburg:generic_database_and_transaction_types
Open
Read-only and read-write Database and Transaction#49cmbrandenburg wants to merge 1 commit intovhbit:masterfrom cmbrandenburg:generic_database_and_transaction_types
cmbrandenburg wants to merge 1 commit intovhbit:masterfrom
cmbrandenburg:generic_database_and_transaction_types
Conversation
This commit unifies the `Transaction` and `ReadonlyTransaction` types into a single `Transaction` type that is generic with respect to whether the transaction is read-only or read-write. There are two new type definitions, `ReadOnlyTransaction` and `ReadWriteTransaction`, which should provide some syntactic sugar for applications. Similarly, this commit changes the `Database` type to be generic with respect to read-only vs read-write access, as well as creating two new type definitions, `ReadOnlyDatabase` and `ReadWriteDatabase`. Read-only databases only provide non-mutating methods. For example, it will be a compiler error for an application to call the `put` method on a `ReadOnlyDatabase`.
Contributor
Author
|
This pull request does not make the Note that this pull request has nothing to do with issue #48. Whereas, this PR deals with read-only vs read-write access, that issue deals with unsafe lifetimes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit unifies the
TransactionandReadonlyTransactiontypesinto a single
Transactiontype that is generic with respect to whetherthe transaction is read-only or read-write. There are two new type
definitions,
ReadOnlyTransactionandReadWriteTransaction, whichshould provide some syntactic sugar for applications.
Similarly, this commit changes the
Databasetype to be generic withrespect to read-only vs read-write access, as well as creating two new
type definitions,
ReadOnlyDatabaseandReadWriteDatabase. Read-onlydatabases only provide non-mutating methods. For example, it will be a
compiler error for an application to call the
putmethod on aReadOnlyDatabase.