refactor(liblmdb-sys): use cc crate instead of gcc#63
Open
elendilm wants to merge 1 commit intovhbit:masterfrom
Open
refactor(liblmdb-sys): use cc crate instead of gcc#63elendilm wants to merge 1 commit intovhbit:masterfrom
elendilm wants to merge 1 commit intovhbit:masterfrom
Conversation
jmaygarden
approved these changes
Dec 1, 2021
jmaygarden
left a comment
jmaygarden
left a comment
There was a problem hiding this comment.
I made these same changes in PR #64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc crate uses the native C compiler to compile C sources. Since gcc has been removed from android ndk, this commit helps to have a seamless compilation for android with cargo build.