Skip to content

Upload data to dataset poc #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proto/viam/app/datasync/v1/data_sync.proto
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ message UploadMetadata {
map<string, google.protobuf.Any> method_parameters = 8;
string file_extension = 9;
repeated string tags = 10;
repeated string dataset_ids = 12;

reserved 4, 11;
reserved "component_model", "session_id";
Expand Down
18 changes: 18 additions & 0 deletions proto/viam/service/datamanager/v1/data_manager.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

package viam.service.datamanager.v1;

import "app/datasync/v1/data_sync.proto";
import "common/v1/common.proto";
import "google/api/annotations.proto";
import "google/protobuf/struct.proto";
Expand All @@ -20,6 +21,11 @@
rpc DoCommand(common.v1.DoCommandRequest) returns (common.v1.DoCommandResponse) {
option (google.api.http) = {post: "/viam/api/v1/service/datamanager/{name}/do_command"};
}

// UploadBinaryDataToDataset uploads raw bytes to a given dataset
rpc UploadRawDataToDataset(UploadBinaryDataToDatasetRequest) returns (UploadBinaryDataToDatasetResponse) {

Check failure on line 26 in proto/viam/service/datamanager/v1/data_manager.proto

View workflow job for this annotation

GitHub Actions / Test For Lint and Breaking Changes

RPC response type "UploadBinaryDataToDatasetResponse" should be named "UploadRawDataToDatasetResponse" or "DataManagerServiceUploadRawDataToDatasetResponse".

Check failure on line 26 in proto/viam/service/datamanager/v1/data_manager.proto

View workflow job for this annotation

GitHub Actions / Test For Lint and Breaking Changes

RPC request type "UploadBinaryDataToDatasetRequest" should be named "UploadRawDataToDatasetRequest" or "DataManagerServiceUploadRawDataToDatasetRequest".
option (google.api.http) = {post: "/viam/api/v1/service/datamanager/{name}/upload_binary_data_to_dataset"};
}
}

message SyncRequest {
Expand All @@ -29,3 +35,15 @@
}

message SyncResponse {}

message UploadBinaryDataToDatasetRequest {
string name = 1;
bytes image = 2;
repeated string tags = 3;
repeated string dataset_ids = 4;
app.datasync.v1.MimeType mime_type = 5;
// Additional arguments to the method
google.protobuf.Struct extra = 99;
}

message UploadBinaryDataToDatasetResponse {}
Loading