Skip to content

RSDK-11268: Handle the prefix field for remotes #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 24, 2025
Merged

RSDK-11268: Handle the prefix field for remotes #727

merged 6 commits into from
Jul 24, 2025

Conversation

jmatth
Copy link
Member

@jmatth jmatth commented Jul 23, 2025

No description provided.

@github-actions github-actions bot added the safe to test committer is a member of this org label Jul 23, 2025
@jmatth jmatth added the ready-for-protos add this when you want protos to compile on every commit label Jul 23, 2025
@jmatth jmatth requested a review from benjirewis July 23, 2025 18:52
@jmatth jmatth marked this pull request as ready for review July 23, 2025 18:53
@@ -293,6 +293,7 @@ message RemoteConfig {

// Secret is a helper for a robot location secret.
string secret = 10;
string prefix = 11;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Could you just document what this field does with a comment?

@jmatth jmatth merged commit ec62933 into main Jul 24, 2025
8 of 9 checks passed
@jmatth jmatth deleted the RSDK-11265 branch July 24, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protos-compiled ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants