-
Notifications
You must be signed in to change notification settings - Fork 48
DOCS-3667: Document annual billing feature for subscription billing model #4447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Thanks for contributing! A reviewer will look at it on the next working day! |
Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.) |
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on this! To clarify a bit, there are only three valid use cases right now:
(1) Monthly, in arrears (the existing behavior):
{
"billing": {
"cost_per_month": {
"per_machine": 10
// ... and any other billable resources, like "binary_data_upload_bytes"
},
"tier_name": "monthly-arrears-tier",
"in_arrears": true
}
}
(2) Monthly, upfront (working on this right now in APP-8350):
{
"billing": {
"cost_per_month": {
"per_machine": 10
},
"tier_name": "monthly-upfront-tier",
"in_arrears": false // or omitted
}
}
(3) Yearly, upfront (the epic's primary goal):
{
"billing": {
"cost_per_year": {
"per_machine": 10
},
"tier_name": "yearly-upfront-tier",
"in_arrears": false // or omitted
}
}
Anything else is invalid. Specifically:
- If
in_arrears
is false, then you can only specify theper_machine
billable resource (it didn't make sense to allow charging for other kinds of usage upfront). - You cannot specify
cost_per_year
andin_arrears: true
(this was more work for us to implement and didn't have a strong product case).
Lmk if I can help clarify anything else!
Updated this, please have another look. My only remaining question is: |
@@ -1,6 +1,7 @@ | |||
### GetCurrentMonthUsage | |||
|
|||
Access data usage information for the current month for a given organization. | |||
Access data usage information for the current billing period for a given organization. | |||
For organizations with monthly billing, this returns current month usage. For organizations with annual billing, this returns usage within the current annual billing cycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for asking – GetCurrentMonthUsage
actually only applies to billing configs that have cost_per_month
with in_arrears: true
. In our backend, we don't consider upfront billing to be "current usage".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a handful of nits, will be good to LGTM right after
@@ -1,6 +1,7 @@ | |||
### GetCurrentMonthUsage | |||
|
|||
Access data usage information for the current month for a given organization. | |||
Access data usage information for the current billing period for a given organization. | |||
For organizations with monthly billing, this returns current month usage. For organizations with annual billing, this returns usage within the current annual billing cycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for asking – GetCurrentMonthUsage
actually only applies to billing configs that have cost_per_month
with in_arrears: true
. In our backend, we don't consider upfront billing to be "current usage".
|
||
By setting `"in_arrears": false` you can change the configuration to charge customers upfront. | ||
|
||
If you want to charge customer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably can remove this?
Co-authored-by: Evgeni Dobranov <[email protected]>
static/include/app/apis/overrides/protos/billing.GetCurrentMonthUsage.md
Outdated
Show resolved
Hide resolved
Thanks @edobranov - should be good to re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looking again, I just have a couple final comments for the FAQ that I think can use a bit more detail 🙏
### Can customers switch from monthly to annual? | ||
|
||
Yes. We recommend that you wait until the end of the current billing cycle to remove the old billing fragment and assign the new billing fragment. | ||
|
||
### Can customers switch from annual to monthly? | ||
|
||
This is not currently possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should actually be okay to switch between the two. Here's my take on a rewrite for both q's (feel free to reword):
### Can customers switch between monthly and annual billing?
Yes. However, switching billing fragments will result in the new charge immediately taking effect.
We recommend that you wait until the end of the current billing cycle to remove the old billing
fragment and assign the new billing fragment.
@edobranov ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % a couple final nits, thank you!
Also could we wait a few days before merging this? I'm still working on the upfront monthly stuff (APP-8350) that's relevant to these docs, but it's taking a bit longer than I anticipated. I'll make sure to ping you when everything is ready to go.
Co-authored-by: Evgeni Dobranov <[email protected]>
Co-authored-by: Evgeni Dobranov <[email protected]>
yes - ping me when ready and we'll merge! |
Main changes: https://deploy-preview-4447--viam-docs.netlify.app/manage/manage/white-labelled-billing/#set-custom-pricing