-
Notifications
You must be signed in to change notification settings - Fork 124
Add PCD to WorldStateStore service fake with color visualization #5311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
GPUBufferAlignment = 256 | ||
|
||
// MinFPS is the minimum non-zero frame rate | ||
MinFPS = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 1 to avoid non-zero altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking is 0 = pause the animation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Maybe just a comment then?
MaxFPS = 144.0 | ||
|
||
// MaxPointCloudSize is the maximum point cloud size | ||
MaxPointCloudSize = 1000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be easy to locally bump to something like 5m? would love to use this to test rendering optimizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bad field name, it's more "max point cloud chunk size" for how large of chunks we are willing to send in a single stream event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! then recommend: MaxPointCloudSizePerChunk
?
go func() { | ||
defer fake.activeBackgroundWorkers.Done() | ||
fake.animationLoop() | ||
fake.animate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
light rec: call this step() since this is more in line with a physics world than a renderer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah these were all just quick names to get the experiment out. I will make another pass on variable/function naming assuming the scope (that I need to write) gets approved.
fpsCheckCounter++ | ||
if fpsCheckCounter%100 == 0 { | ||
worldState.mu.RLock() | ||
newFPS := worldState.fps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would also probably call anything FPS related "ticksPerSecond" or "stepsPerSecond" since there's no rendering in this context but that's a bigger lift
Adds a PCD to the world state store service visualization to test loading and rendering. We add color to the point cloud by normalized height, and then apply noise and recalculate colors at 1000 points per tick.
Also fixes some animation logic (y vs. z axis swapped) and improves general code cleanliness for maintainability, making this a better example for implementors of world state store service modules.
Screen.Recording.2025-10-06.at.9.28.46.AM.mov