Skip to content

Conversation

@erh
Copy link
Member

@erh erh commented Nov 26, 2025

No description provided.

@erh erh requested a review from dgottlieb November 26, 2025 23:34
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 26, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 27, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 27, 2025
@github-actions
Copy link
Contributor

Availability

Scene # viamrobotics:main erh:20251126-no-crash Percent Improvement Health
1 100% 100% 0%
2 100% 100% 0%
3 100% 100% 0%
4 100% 100% 0%
5 100% 100% 0%
6 100% 100% 0%
7 100% 100% 0%
8 100% 100% 0%
9 100% 100% 0%
10 100% 100% 0%
11 100% 100% 0%

Quality

Scene # viamrobotics:main erh:20251126-no-crash Percent Improvement Probability of Improvement Health
1 1.31±0.00 1.31±0.00 -0% 38%
2 0.90±0.00 0.90±0.00 -0% 50%
3 5.88±0.11 5.99±0.15 -2% 28%
4 3.29±0.39 3.27±0.37 1% 52%
5 8.87±2.40 9.16±2.50 -3% 47%
6 10.31±2.25 10.53±2.23 -2% 47%
7 6.24±2.37 5.19±2.56 17% 62%
8 0.90±0.00 0.90±0.00 -0% 50%
9 4.29±0.19 4.29±0.19 -0% 50%
10 12.77±0.44 12.77±0.44 -0% 50%
11 0.62±0.00 0.62±0.00 0% 68%

Performance

Scene # viamrobotics:main erh:20251126-no-crash Percent Improvement Probability of Improvement Health
1 0.03±0.00 0.03±0.00 11% 73%
2 0.03±0.00 0.03±0.01 3% 57%
3 0.03±0.00 0.04±0.01 -13% 23%
4 0.16±0.03 0.15±0.03 7% 60%
5 1.41±0.11 1.42±0.11 -1% 46%
6 1.80±0.47 1.82±0.48 -1% 49%
7 2.23±1.39 2.41±1.66 -8% 47%
8 0.03±0.00 0.03±0.00 -1% 44%
9 1.45±0.08 1.45±0.09 0% 52%
10 3.03±0.47 2.86±0.42 6% 61%
11 0.63±0.05 0.64±0.06 -2% 45%

The above data was generated by running scenes defined in the motion-testing repository
The SHA1 for viamrobotics:main is: 0e931489d131bab9318e21e661bd8bd8d4c13ade
The SHA1 for erh:20251126-no-crash is: 0e931489d131bab9318e21e661bd8bd8d4c13ade

  • 11 samples were taken for each scene

Copy link
Member

@dgottlieb dgottlieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is appearing is related to https://viam.atlassian.net/browse/RSDK-12629 or https://viam.atlassian.net/browse/RSDK-12704

Right now we do have a problem when components with geometries don't configure or become unavailable for other reasons (e.g: remotes).

Though I would expect those changes would still only pass connected pieces between the RDK framesystem -> motion planning.

Also not sure if we observed this in the RDK proper or sandings usage of motion planning as a library. I'm realizing I don't 100% know how sanding gets a handle on the frame system.

@erh erh merged commit e1682c2 into viamrobotics:main Dec 1, 2025
19 checks passed
@erh erh deleted the 20251126-no-crash branch December 1, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants