Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset stream in camera_stream if camera changes #305

Merged
merged 1 commit into from
Nov 25, 2024
+16 −3
Merged

Reset stream in camera_stream if camera changes #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions lib/widgets/camera_stream.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,18 @@ class _ViamCameraStreamViewState extends State<ViamCameraStreamView> {
_startStream();
}

@override
void didUpdateWidget(ViamCameraStreamView oldWidget) {
super.didUpdateWidget(oldWidget);
if (oldWidget.camera != widget.camera) {
_cleanupStream();
_startStream();
}
}

@override
void dispose() {
_renderer.dispose();
_streamSub.cancel();
widget.streamClient.closeStream();
_cleanupStream();
super.dispose();
}

Expand Down Expand Up @@ -70,6 +77,12 @@ class _ViamCameraStreamViewState extends State<ViamCameraStreamView> {
});
}

void _cleanupStream() {
_renderer.dispose();
_streamSub.cancel();
widget.streamClient.closeStream();
}

@override
Widget build(BuildContext context) {
return (_error != null)
Expand Down
Loading