Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-9250] - Add stream options handlers #308

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

seanavery
Copy link
Member

Description

Adds handlers to the stream and robot client to hit options endpoints.

Tests

Tested using local flutter web app that fires the following code block.

    final machine = await RobotClient.atAddress(
      host,
      RobotClientOptions.withApiKey(apiKeyID, apiKey),
    );
    final res = await machine.getStreamOptions("wc-cam");
    print(res);
    await machine.setStreamOptions("wc-cam", res[1].width, res[1].height);
    await machine.resetStreamOptions("wc-cam");
    await machine.close();

@seanavery seanavery requested a review from a team as a code owner November 27, 2024 20:10
@seanavery seanavery merged commit fc84a99 into viamrobotics:main Dec 3, 2024
4 checks passed
@kevin49999
Copy link
Member

@seanavery is there a way you could see what options a stream is currently running with?

@seanavery
Copy link
Member Author

@kevin49999 Currently there is not an easy way to look this up with an API call.. Would this be helpful for the frontend?

@kevin49999
Copy link
Member

@kevin49999 Currently there is not an easy way to look this up with an API call.. Would this be helpful for the frontend?

It could be helpful, right now we will have a few redundant setStreamOptions calls. Though it doesn't seem like it's a big deal.

If we could read the current options I was thinking of using that to avoid calling set stream if it's already been done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants