DATA-3398: Add GetLatestTabularData endpoint to Flutter SDK #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaywux
reviewed
Dec 6, 2024
There was a problem hiding this comment.
The GetLatestTabularData additions LGTM! Thanks for the quick work here Vignesh :)
Quick question before official approval - there are a lot of changes in the test/unit_test/mocks/service_clients_mocks.mocks.dart file (which looks like generated code) - any idea what caused these unrelated changes?
|
I'm not the most familiar with flutter, but I suspect that I am the first one to regenerate the mock functions in a while and maybe people have made changes and just not regenerated the mock functions when they did. Definitely would appreciate some feedback from someone more experienced though. |
njooma
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a new Data endpoint GetLatestTabularData viamrobotics/app#6896, this PR adds the endpoint to Flutter SDK.