Add includeBinary to data funcs #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
approved these changes
Jan 22, 2025
purplenicole730
approved these changes
Jan 23, 2025
| final response = await dataClient.binaryDataByIds(ids); | ||
| expect(response, equals(data)); | ||
| final response = await dataClient.binaryDataByIds(ids, includeBinary: true); | ||
| expect(response.data, equals(data)); |
There was a problem hiding this comment.
Should we not test response.count as well now that the response has changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
We were missing the param to actually download the data. In the process of changing that, I had to change the return type of
binaryDataByIDssince the user can request just the count now.As a flyby, I fixed
binaryDataByFilterto actually usecountOnly