DATA-3396: Add GetLatestTabularData endpoint to TypeScript SDK #419
Conversation
| resourceName: string, | ||
| resourceSubtype: string, |
There was a problem hiding this comment.
How would y'all feel about swapping these 2? I kinda like the idea of progressive specificity -- go from least specific (part) to most specific (method name).
So the order would be part -> subtype -> name -> method
There was a problem hiding this comment.
I think if you guys don't mind, we'd like to keep the order as is, at least in this PR - this follows the existing ordering convention for data that's shown in the UI, among other places. We're already exposing this ordering to users (below is a screenshot from the image / sensor view's filter panel) so would like to keep things consistent.
Of course, happy to discuss further on this - the field order switch could definitely be a larger change across data
🔗 Link your GitHub account to AtlassianTo enable Code Reviewer, please link your GitHub account to your Atlassian account. Click here to connect your accounts This is a one-time setup that takes less than a minute. |
3 participants
We added a new Data endpoint GetLatestTabularData https://github.com/viamrobotics/app/pull/6896, this PR adds the endpoint to Typescript SDK.