APP-7497: Add Button interface and client #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
reviewed
Jan 28, 2025
| } | ||
|
|
||
| async press(extra = {}, callOptions = this.callOptions) { | ||
| const request = new PushRequest({ |
Member
There was a problem hiding this comment.
Why call the client method press when the API method is push?
Contributor
Author
There was a problem hiding this comment.
Lol whoops - I blame Claude/Cursor 🤣 thanks for the catch
ethanlookpotts
force-pushed
the
APP-7497/ethanlookpotts/button
branch
from
ee3188e to
9488823
Compare
njooma
approved these changes
Jan 28, 2025
stuqdog
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new Button API type to the TypeScript SDK using the following API: https://github.com/viamrobotics/api/blob/main/proto/viam/component/button/v1/button.proto
This will get used in the new control cards to render a button card and call the Push API.
Change log