Add ml model service #469
Merged
Add ml model service #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaporter-work
approved these changes
Feb 12, 2025
Contributor
zaporter-work
left a comment
zaporter-work
left a comment
There was a problem hiding this comment.
LGTM (have not manually tested this)
bhaney
approved these changes
Feb 12, 2025
micheal-parks
approved these changes
Feb 13, 2025
src/services/ml-model/index.ts
Outdated
Comment on lines
3
to
7
| export type { | ||
| FlatTensors, | ||
| InferResponse, | ||
| MetadataResponse, | ||
| } from '../../gen/service/mlmodel/v1/mlmodel_pb'; |
Member
There was a problem hiding this comment.
From what I know, we don't directly export proto types. There are other instances when we export after using shadow types (i.e. in the navigation service and movement sensor component)
Member
Author
There was a problem hiding this comment.
That makes sense, I will update them to shadow types. I also may just reduce it to the FlatTensors shape, since they other are response shapes but FlatTensors is used as an argument for one of the APIs, so I could see users wanting to pre-construct that before passing it along.
…to add-ml-model-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an incoming request to render the response of the
Metadata()in the test controls for the ML Model Service card. This exposes themetadataAPI to be used.