Make client name field public #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaporter-work
approved these changes
Feb 18, 2025
Contributor
zaporter-work
left a comment
zaporter-work
left a comment
There was a problem hiding this comment.
I'm in favor of this change -- svelte-sdk has to pair clients and their names together. If this info was on the client, it would simplify our code.
Are there any downsides to this?
Member
Author
|
I don't see any. It's still readonly, and the user knows the name of the client when passing it to the constructor. This is useful metadata that should be made available IMO. In non-ts-land people can already read (and change) this value since all modifiers are compiled away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
It's often useful to read the corresponding resource name from a client, for example when executing requests on the
robotClientin a scope where only a resource client and not the original resource name is available. In this PR I've switched all names to public but kept the readonly modifier.