Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Optimized the solution for Advent of Code 2019 Day 18.
Key changes:

  1. A Algorithm*: Replaced the Dijkstra search with A*. Implemented a heuristic that estimates the remaining cost by summing the maximum distance from each robot to its furthest uncollected assigned key. This significantly prunes the search space.
  2. Bug Fix: Corrected the stride used for the visited array in KeyGraph::new BFS (was using height, now using width).
  3. Cleanup: Removed the unused priority_queue import.
  4. Verification: Added a unit test with a standard example to ensure correctness.

PR created automatically by Jules for task 14614951169114204466 started by @viandoxdev

- Switched from Dijkstra to A* algorithm using an admissible heuristic (max distance to remaining keys).
- Fixed a bug in `KeyGraph::new` where `grid.height` was used as stride instead of `grid.width` for `visited` array.
- Removed unused `priority_queue` dependency.
- Added a test case with example input to verify correctness.
- This optimization aims to reduce runtime to under 10ms.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@viandoxdev viandoxdev marked this pull request as ready for review November 23, 2025 22:50
Copy link
Owner

@viandoxdev viandoxdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever going to test locally anyways (and cleanup)

@viandoxdev viandoxdev merged commit c599a91 into main Nov 23, 2025
1 check passed
viandoxdev added a commit that referenced this pull request Dec 6, 2025
viandoxdev added a commit that referenced this pull request Dec 6, 2025
Optimize 2019 Day 18 with A* and fix grid stride bug
(Testing AI stuff idk)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants