-
Notifications
You must be signed in to change notification settings - Fork 6
Assigment Dries #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ddebeer for your submission!
|
||
|
||
# Setup an app user so the container doesn't run as the root user | ||
# RUN useradd app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting suggestion which we could apply in other edition
@@ -7,7 +7,7 @@ | |||
app = Flask(__name__) | |||
|
|||
# Check if the model file exists and wait until it does | |||
model_path = '/app/models/iris_model.pkl' | |||
model_path = '/app/iris_model.pkl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, works as well
@@ -12,6 +12,6 @@ | |||
model = clf.fit(iris.data, iris.target_names[iris.target]) | |||
|
|||
#Save the trained model to the shared volume (make sure to use the correct path) | |||
joblib.dump(model, '/app/models/iris_model.pkl') | |||
joblib.dump(model, '/app/iris_model.pkl') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, works as well
No description provided.