Skip to content

Add an overshoot output for module LoudnessMeter #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarkRedman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add an overshoot output for module LoudnessMeter #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/LoudnessMeter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ struct LoudnessMeterWidget : ModuleWidget {
addInput(createInputCentered<ThemedPJ301MPort>(Vec(22.5f, inputYPx), module, LoudnessMeter::AUDIO_INPUT_L));
addInput(createInputCentered<ThemedPJ301MPort>(Vec(67.5f, inputYPx), module, LoudnessMeter::AUDIO_INPUT_R));
addInput(createInputCentered<ThemedPJ301MPort>(Vec(112.5f, inputYPx), module, LoudnessMeter::RESET_INPUT));
addOutput(createOutputCentered<ThemedPJ301MPort>(Vec(196.760f, 361.120f), module, LoudnessMeter::OVERSHOOT_OUTPUT));
addParam(createParamCentered<VCVButton>(Vec(157.5f, inputYPx), module, LoudnessMeter::RESET_PARAM));
addParam(createParamCentered<RoundSmallBlackKnob>(Vec(202.5f, inputYPx), module, LoudnessMeter::TARGET_PARAM));

Expand Down
13 changes: 12 additions & 1 deletion src/LoudnessMeterEngine.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ struct LoudnessMeter : engine::Module {
RESET_INPUT,
NUM_INPUTS
};
enum OutputIds { NUM_OUTPUTS };
enum OutputIds {
OVERSHOOT_OUTPUT,
NUM_OUTPUTS
};
enum LightIds { NUM_LIGHTS };

// Enum for processing modes
Expand Down Expand Up @@ -92,6 +95,7 @@ struct LoudnessMeter : engine::Module {
configInput(AUDIO_INPUT_L, "Audio L / Mono");
configInput(AUDIO_INPUT_R, "Audio R");
configInput(RESET_INPUT, "Reset");
configOutput(OVERSHOOT_OUTPUT, "Overshoot");
configParam(TARGET_PARAM, -36.f, 0.f, -23.f, "Target loudness", " LUFS");
configParam(RESET_PARAM, 0.f, 1.f, 0.f, "Reset");

Expand Down Expand Up @@ -460,6 +464,13 @@ struct LoudnessMeter : engine::Module {
if (bufferPosition >= PROCESSING_BLOCK_FRAMES) {
processBlockBuffer();
}

float targetValue = params[TARGET_PARAM].getValue();
float overshoot = momentaryLufs - targetValue;
float overshootVoltage = overshoot / 20.f * 10.f;

overshootVoltage = clamp(overshootVoltage, -10.f, 10.f); // Ensure within -10V to +10V
outputs[OVERSHOOT_OUTPUT].setVoltage(overshootVoltage);
}

json_t* dataToJson() override {
Expand Down