Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging to help diagnose playback issues #98

Merged
merged 8 commits into from
Oct 30, 2018

Conversation

bikegriffith
Copy link
Contributor

Simply register a global window.ClapprRTMPLog function, which will be called from the swf via ExternalInterface to see log messages, e.g.:

<script>
function ClapprRTMPLog(msg) {
  console.log("[clappr-rtmp-plugin] " + msg);
}
</script>

@flavioribeiro flavioribeiro merged commit 745a9d8 into video-dev:master Oct 30, 2018
@flavioribeiro
Copy link
Member

@bikegriffith what happens if ClapprRTMPLog function doesn't exist on the window context?

@bikegriffith
Copy link
Contributor Author

Seems to just fail silently in my testing

@flavioribeiro
Copy link
Member

also, I'm wondering if https://github.com/video-dev/clappr-rtmp-plugin/pull/98/files#diff-7dfb85a40bf4906bf76c43e666dea9e6R398 shouldn't be placed inside the CONFIG::LOGGING block. In practice, it should always be a way to have a no-debugging build for production purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants