Skip to content

Fix compiler warnings #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compiler warnings #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions scte/35.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,18 +547,18 @@ static inline bool scte35_insert_validate(const uint8_t *p_scte35)

if (i_length < SCTE35_INSERT_HEADER_SIZE + SCTE35_INSERT_HEADER2_SIZE +
SCTE35_SPLICE_TIME_HEADER_SIZE ||
i_length < SCTE35_INSERT_HEADER_SIZE + SCTE35_INSERT_HEADER2_SIZE +
i_length < (size_t)SCTE35_INSERT_HEADER_SIZE + SCTE35_INSERT_HEADER2_SIZE +
scte35_splice_time_size(
scte35_insert_get_splice_time(p_scte35)))
return false;

if (scte35_insert_has_duration(p_scte35))
return i_length >= SCTE35_INSERT_HEADER_SIZE +
return i_length >= (size_t)SCTE35_INSERT_HEADER_SIZE +
SCTE35_INSERT_HEADER2_SIZE +
scte35_splice_time_size(scte35_insert_get_splice_time(p_scte35))
+ SCTE35_BREAK_DURATION_HEADER_SIZE +
SCTE35_INSERT_FOOTER_SIZE;
return i_length >= SCTE35_INSERT_HEADER_SIZE +
return i_length >= (size_t)SCTE35_INSERT_HEADER_SIZE +
SCTE35_INSERT_HEADER2_SIZE +
scte35_splice_time_size(scte35_insert_get_splice_time(p_scte35))
+ SCTE35_INSERT_FOOTER_SIZE;
Expand All @@ -575,9 +575,9 @@ static inline bool scte35_insert_validate(const uint8_t *p_scte35)
return false;

if (scte35_insert_has_duration(p_scte35))
return i_length >= p_end + SCTE35_BREAK_DURATION_HEADER_SIZE +
SCTE35_INSERT_FOOTER_SIZE - p_command;
return i_length >= p_end + SCTE35_INSERT_FOOTER_SIZE - p_command;
return i_length >= (size_t)(p_end + SCTE35_BREAK_DURATION_HEADER_SIZE +
SCTE35_INSERT_FOOTER_SIZE - p_command);
return i_length >= (size_t)(p_end + SCTE35_INSERT_FOOTER_SIZE - p_command);
}

/*****************************************************************************
Expand Down