fix: harden downstream release validate and rollback context#422
Merged
c-vigo merged 1 commit intorelease/0.3.1from Mar 23, 2026
Merged
fix: harden downstream release validate and rollback context#422c-vigo merged 1 commit intorelease/0.3.1from
c-vigo merged 1 commit intorelease/0.3.1from
Conversation
There was a problem hiding this comment.
Pull request overview
Hardens the downstream (workspace template) release orchestration to avoid failures when validating/publishing from within containerized jobs, and ensures rollback reporting works even when git checkout is skipped.
Changes:
- Remove container-side image manifest validation (
docker manifest inspect) from therelease-core.ymlvalidate job. - Provide explicit
GH_REPOcontext for rollbackgh issue createinrelease.ymlwhen checkout is not present. - Document the fix in both the root and workspace template changelogs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CHANGELOG.md | Adds a 0.3.1 “Fixed” entry describing the downstream validate/rollback hardening. |
| assets/workspace/.devcontainer/CHANGELOG.md | Mirrors the same changelog entry in the workspace template payload. |
| assets/workspace/.github/workflows/release-core.yml | Removes redundant/failing container-side docker manifest inspect validation step. |
| assets/workspace/.github/workflows/release.yml | Sets GH_REPO for the rollback “Create failure issue” step to keep gh working without checkout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses smoke-test dispatch failure in downstream release orchestration (#421):
trigger-releasefailed while validating the image from inside the devcontainer job. The validate job no longer runsdocker manifest inspectin the container (redundant with runner-sideresolve-imageand the running image). Rollbackgh issue createnow receivesGH_REPOwhen the job skips checkout soghhas an explicit repository context.Type of Change
feat-- New featurefix-- Bug fixdocs-- Documentation onlychore-- Maintenance task (deps, config, etc.)refactor-- Code restructuring (no behavior change)test-- Adding or updating testsci-- CI/CD pipeline changesbuild-- Build system or dependency changesrevert-- Reverts a previous commitstyle-- Code style (formatting, whitespace)Modifiers
!) -- This change breaks backward compatibilityChanges Made
CHANGELOG.md— document fix under## [0.3.1] - TBD/### Fixedassets/workspace/.devcontainer/CHANGELOG.md— mirror changelog entryassets/workspace/.github/workflows/release-core.yml— remove containerdocker manifest inspectstep from validate jobassets/workspace/.github/workflows/release.yml— setGH_REPO: ${{ github.repository }}for rollbackgh issue createenvChangelog Entry
Target branch is
release/0.3.1; there is no## Unreleasedsection. Entry was added under## [0.3.1] - TBD→### Fixed:Testing
just test)Manual Testing Details
uv run pre-commit run --all-filespassed on the branch before commit.Checklist
docs/templates/, then runjust docs)CHANGELOG.mdin the[Unreleased]section (and pasted the entry above)Additional Notes
N/A
Refs: #421