Add weather reporting functionality to Assistant#59
Merged
vihar-s1 merged 1 commit intovihar-s1:mainfrom Feb 1, 2025
AmanDevelops:weather
Merged
Add weather reporting functionality to Assistant#59vihar-s1 merged 1 commit intovihar-s1:mainfrom AmanDevelops:weather
vihar-s1 merged 1 commit intovihar-s1:mainfrom
AmanDevelops:weather
Conversation
vihar-s1
reviewed
Jan 30, 2025
Owner
vihar-s1
left a comment
vihar-s1
left a comment
There was a problem hiding this comment.
Please share a short video demonstrating the feature
Contributor
Author
here is the required video demonstration @vihar-s1 screen-recorder-fri-jan-31-2025-00-39-43.webm |
Owner
|
sorry for the delay @AmanDevelops...was busy with office work...will review your PRs by EOD today |
vihar-s1
approved these changes
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Referenced
closes #47
Describe the Changes
Change 1: assistant.py
added a query processor for calling the weather_reporter function
Change 2: commands.py
implementation of weather_reporter function:
Type of Change
Additional Setup Requirements
No Response
Necessary Conditions
Please make sure to check the following milestones before submitting the bug report!