Most mandatories are done. #21
Open
Steven-Chang wants to merge 76 commits into
Open
Conversation
added 30 commits
October 3, 2016 10:19
…ith directives and a shared templates
…vides just the array of results
…hows the prices for that stock a day ago, 7 days ago and thirty days ago
…rent price - the price on that day
…re people can scroll to find the stock they want
…s connected to the names and symbols objects. Works :) although a bit slow
…request for everything becauuse Yahoo won't let you
… by date object instead of the results array. This is better as it will take care of situations where if there are a bunch of different stock and some don't have stock data, the overall data will still be accurate
… search and results box happens once a successful search happens
…ice but yet to fully utilize
…o that i can keep the right handside have their own controllers without nesting. Also moved the date range slider to the left hand side
…ecessary services
added 30 commits
October 16, 2016 16:22
…when user was in sell mode
…ut in terms of future sales
…nd objects over there
… trade controller, user service have had a massive refactoring so things connect up easier
…fferent main views. Seems to work fine but still need to add the dropdown and the filter
…a bit of cleaning up
…date and symbol and glyphicons are working appropriately
…er is there, except the content
… is that trade functionality works on default date when user makes a request
…basis is working but it doesn't filter out dates that are in the future yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some features that made some parts of the assignment hard to do