proj. danebook#32
Open
asackofwheat wants to merge 15 commits into
Open
Conversation
| end | ||
|
|
||
| def destroy | ||
| @user = User.find(params[:user_id]) |
There was a problem hiding this comment.
I don't think the user has to be in here, since you don't user the user.
| end | ||
| end | ||
|
|
||
| def destroy |
There was a problem hiding this comment.
by not using current user in this, I think you leave yourself open to someone being to change the params within the element and then delete posts that are not theirs. I'll check it out in the live app and let you know.
Update: Yes, I can delete posts that are not mine, by going to the delete link in the post that is mine and changing the href.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.