Skip to content

project_danebook#49

Open
KenKot wants to merge 62 commits into
vikingeducation:masterfrom
KenKot:master
Open

project_danebook#49
KenKot wants to merge 62 commits into
vikingeducation:masterfrom
KenKot:master

Conversation

@KenKot

@KenKot KenKot commented Dec 10, 2016

Copy link
Copy Markdown

No description provided.

@SampsonCrowley

Copy link
Copy Markdown

opening the root url ("/") while logged in does not redirect back to a signed in page or give any indication of being still logged in.

recommended to add a condition to your signup url to redirect to the user's timeline if logged in

@SampsonCrowley

Copy link
Copy Markdown

Shows current user's birthday on all pages instead of profile I'm viewing. don't overuse current user.

use @user when viewing info and current user when editing info

@SampsonCrowley

SampsonCrowley commented Dec 10, 2016

Copy link
Copy Markdown

users/1/timeline path is non-existant

clicking the timeline button in the navbar causes application failure.

make the link a dead link until you are ready to implement

recommended to use the users#index for your main timeline, and users#show as individual timelines.

then you can keep your users#profiles#show for profile pages

@SampsonCrowley

Copy link
Copy Markdown

can't make posts or comments. no path available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants