Skip to content

Pin Actions to commit SHAs#25

Merged
malone-at-work merged 1 commit into
villagesql:mainfrom
pyshx:migrate-actions-node24
Jun 30, 2026
Merged

Pin Actions to commit SHAs#25
malone-at-work merged 1 commit into
villagesql:mainfrom
pyshx:migrate-actions-node24

Conversation

@pyshx

@pyshx pyshx commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Pins all third-party actions to commit SHAs. Companion to the Node 20 deprecation work in villagesql/villagesql-server#616.

  • Pin actions/checkout (v6.0.3), actions-rust-lang/setup-rust-toolchain (v1.16.1), actions/cache (v5.0.5), dawidd6/action-download-artifact (v21), actions/upload-artifact (v7.0.1) to commit SHAs — all already on Node 24
  • Pin rustsec/audit-check to its v2.0.0 SHA (still Node 20; no Node 24 release exists yet)
  • Add top-level permissions: contents: read (the audit job keeps its own checks: write)

SHAs were resolved from each action's release tag. Validated with actionlint.

Comment thread .github/workflows/ci.yml Outdated
name: Formatting
runs-on: ubuntu-latest
steps:
- name: Harden the runner

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not add the harden the runner step to these yet? It broadens the supply chain, and I am not familiar with it, nor is anyone else I have spoken to at villageSQL.

@pyshx pyshx force-pushed the migrate-actions-node24 branch from c27fd06 to 5590d35 Compare June 9, 2026 13:56
See villagesql/villagesql-server#616 (migrate GitHub Actions off the deprecated Node 20 runtime).
@pyshx pyshx force-pushed the migrate-actions-node24 branch from 5590d35 to 1faeed7 Compare June 9, 2026 14:03
@pyshx pyshx changed the title Pin Actions to commit SHAs and add harden-runner Pin Actions to commit SHAs Jun 9, 2026
@malone-at-work

Copy link
Copy Markdown
Member

I didn't realize this was pending, it didn't show up in my dashboard because you didn't re-request my review... Submitting now.

@malone-at-work malone-at-work merged commit 058e6c4 into villagesql:main Jun 30, 2026
10 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants