Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

VIM-XXXX: Add default implementation for 'ended' property #95

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Jumhyn
Copy link
Contributor

@Jumhyn Jumhyn commented Sep 23, 2019

Ticket

  • N/A

Pull Request Checklist

  • Resolved any merge conflicts
  • No build errors or warnings are introduced
  • New files are written in Swift
  • New classes contain license headers
  • New classes have Documentation
  • New public methods have Documentation

Issue Summary

  • Outline the goals of the PR in technical terms. If this branch fixes a bug, state what caused the bug.

Implementation Summary

  • Identify the core components that were added or changed, and briefly state the reasoning behind these changes.

  • List any key assumptions made.

Reviewer Tips

  • Provide the order in which files or components should be reviewed.

  • List the general components that this PR will affect.

  • Identify any copy and pasted code with a large diff.

How to Test

  • Identify necessary conditions for testing (e.g. logged out, bad connectivity).

  • If a special type of account is needed for log in, contact a developer privately to provide credentials.

Copy link
Contributor

@rpassis rpassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants