fix(artifacts): fail open when optional stats cannot be written - #216
Open
hxy91819 wants to merge 1 commit into
Open
fix(artifacts): fail open when optional stats cannot be written#216hxy91819 wants to merge 1 commit into
hxy91819 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Optional telemetry used the same strict metadata writer as explicit artifact storage. An EROFS or ENOTDIR error therefore replaced an already completed command result, including explicit raw output.
Tests
env -u TOKENJUICE_NO_OMISSION pnpm exec vitest run test/core/wrap.test.ts -t "preserves raw output when optional stats cannot be written|keeps explicit artifact storage failures strict"env -u TOKENJUICE_NO_OMISSION pnpm exec vitest run test/hosts/codex.test.ts -t "keeps raw bypasses fail-open when optional stats cannot be written"pnpm lintpnpm typecheckImpact
No documentation, packaging, or release behavior changes. Explicit storage remains strict.