Merged
Conversation
The branch detection algorithm now requires that overlap covers at least 50% of the item's duration before creating a visual branch. This prevents brief job transitions (starting a new role a few months before leaving the old one) from triggering the branch visualization, which looked broken when the overlap was minor relative to the job's total duration. https://claude.ai/code/session_017GNjmnVbiG7o17kAEUEZfe
…ot on iOS print - Replace 50% duration threshold with simple 3-month minimum overlap. The percentage check was too aggressive: long-duration items with substantial overlaps (e.g. 18 months) wouldn't branch if the overlap was less than half the item's total duration. - Fix floating dot on iOS print by using CSS branch line fallback instead of SVG (Safari iOS doesn't render SVGs reliably in print). - Fix incorrect beforeprint height reduction (66px based on stale comment about padding changes that don't exist — padding is 70px in both screen and print). Reduced to 20px to match actual element size differences. https://claude.ai/code/session_01MpnNxvA1HW5TpZa3jnFCRS
Reverts the SVG hiding, CSS fallback, and beforeprint height changes from the previous commit. Only the 3-month overlap threshold fix is kept. The iPhone floating dot is a niche issue not worth breaking desktop S-curves and iPhone branch rendering for. https://claude.ai/code/session_01MpnNxvA1HW5TpZa3jnFCRS
The dotClearance nudge + 24px curveW could push the branch line start past the first branch item's dot (and similarly for the merge end past the last branch item's dot), leaving dots visually disconnected from the branch. Now clamp fork/merge positions to ensure the branch line always reaches all branch-track dots. https://claude.ai/code/session_01MpnNxvA1HW5TpZa3jnFCRS
When a long-running position (e.g. a side job) overlaps with multiple sequential main positions, short intermediate items that don't meet the 3-month overlap threshold would break the branch into separate segments, causing visual merge-back + re-fork clutter. Now extend an existing branch when the new item's branchPartner matches the branch's forkBeforeIdx (same main-track anchor = same parallel employment period), keeping one continuous branch line regardless of gaps in the segment index. https://claude.ai/code/session_01MpnNxvA1HW5TpZa3jnFCRS
The flat 3-month overlap threshold excluded short items (e.g. a 2-month acting role) that fall entirely within a parallel employment period. Now branch if overlap >= 3 months OR if the overlap covers the item's entire duration, so short items stay on the branch where they belong. https://claude.ai/code/session_01MpnNxvA1HW5TpZa3jnFCRS
Explains when branches are created (3+ months overlap), the short-duration exception (items entirely within another position's range), continuous branch behavior (same long-running anchor), and when branches are NOT created (1-2 month transitions, no overlap, insufficient space). https://claude.ai/code/session_01MpnNxvA1HW5TpZa3jnFCRS
Deploying cv-manager with
|
| Latest commit: |
8ac38bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd78c069.cv-manager-a5e.pages.dev |
| Branch Preview URL: | https://claude-fix-timeline-layout-i.cv-manager-a5e.pages.dev |
The overflow:hidden added to .timeline-container clips branch-track elements and SVG S-curves on iOS Safari's print renderer — child overflow:visible cannot escape a clipped parent. Add overflow:visible !important in the @media print rule for the container. Bump version 1.12.1 → 1.12.2. https://claude.ai/code/session_01MpnNxvA1HW5TpZa3jnFCRS
Two issues caused by divergence from main's print CSS: 1. Branch line invisible: iOS Safari doesn't render SVGs in print. Main had a CSS fallback `.timeline-branch-line` with display:block in the print media query; this branch had set it to display:none. Restored the CSS fallback — it sits at z-index:1 underneath the SVG curves (z-index:2), so desktop sees the SVG while iPhone falls back to the CSS line. 2. Cards overlapping header: main had `transform: translateX(-50%) !important` on .timeline-content in print, ensuring cards stay centered. This branch removed it in favor of JS-computed inline `left` positioning, which iOS Safari's print renderer doesn't apply reliably. Restored CSS-based centering for print and hide connector lines (which depend on the JS offsets). Bump 1.12.2 → 1.12.3. https://claude.ai/code/session_01MpnNxvA1HW5TpZa3jnFCRS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.