Fix admin login 500: eliminate double-commit in get_master_db dependency#21
Closed
vincentmakes wants to merge 1 commit intomainfrom
Closed
Fix admin login 500: eliminate double-commit in get_master_db dependency#21vincentmakes wants to merge 1 commit intomainfrom
vincentmakes wants to merge 1 commit intomainfrom
Conversation
The `get_master_db` dependency wrapped `master_db.session()` which auto-commits after yield, but admin route handlers also commit explicitly — causing a double-commit. More critically, the `except Exception` block in the auto-commit context manager intercepted HTTPExceptions during FastAPI's dependency cleanup, converting expected 401 responses into 500 Internal Server Errors. Changes: - get_master_db now uses session_factory() directly (no auto-commit) - Test conftest overrides get_master_db so admin routes are testable - Add 8 admin auth tests (login, logout, session check) https://claude.ai/code/session_01MDSKNbWA93pkLGyr2xMRYX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_master_dbdependency wrappedmaster_db.session()which auto-commits after yield, but admin route handlers also commit explicitly — causing a double-commit. More critically, theexcept Exceptionblock in the auto-commit context manager intercepted HTTPExceptions during FastAPI's dependency cleanup, converting expected 401 responses into 500 Internal Server Errors.Changes:
https://claude.ai/code/session_01MDSKNbWA93pkLGyr2xMRYX