Fix non stop florestad process in functional tests #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qlrd
changed the title
Davidson-Souza
requested changes
Mar 31, 2025
qlrd
force-pushed
the
fix-non-stop-florestad-process
branch
2 times, most recently
from
c3a39ce to
4376c06
Compare
21 tasks
qlrd
force-pushed
the
fix-non-stop-florestad-process
branch
3 times, most recently
from
a6efc87 to
1912458
Compare
jaoleal
reviewed
Apr 3, 2025
qlrd
force-pushed
the
fix-non-stop-florestad-process
branch
2 times, most recently
from
fa80b11 to
005fb13
Compare
qlrd
force-pushed
the
fix-non-stop-florestad-process
branch
5 times, most recently
from
b24d0e4 to
eda92cf
Compare
qlrd
force-pushed
the
fix-non-stop-florestad-process
branch
3 times, most recently
from
db17b6a to
debf6d0
Compare
jaoleal
approved these changes
Apr 9, 2025
Sure, i was talking right now with @Davidson-Souza about. He requested, however, to keep the commits of each suite separate. |
qlrd
force-pushed
the
fix-non-stop-florestad-process
branch
from
debf6d0 to
a3e64e3
Compare
|
ACK a3e64e3 |
Fix vinteumorg#426. The methods below, in addition to performing case assertions, stop all running nodes if an assertion fails: * assertTrue for boolean condition; * assertIsNone for None values; * assertIsSome for non-None values; * assertEqual for equality conditions; * assertIn for expected item in a list; * assertMatch for expected strings in a given regex pattern; * assertRaises for expected exceptions. Update
* addnode; * getblock; * getblockchaininfo; * getblockhash; * getmemoryinfo; * getpeerinfo; * getroots; * getrpcinfo; * stop; * uptime.
* restart; * ssl (TLS communication with a ssl-enabled node); * ssl-fail (failure on a TLS communication with non-ssl node).
qlrd
force-pushed
the
fix-non-stop-florestad-process
branch
from
a3e64e3 to
bcb64d5
Compare
jaoleal
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #426
What is the purpose of this pull request?
Which crates are being modified?
Description
Added a pipeline for assertions, where a failure of a condition start a node's shutdown procedure. The pipeline can be used with these methods:
assertTrue for boolean condition;
assertEqual for expected general condition;
assertIn for expected item in a list;
assertMatch for expected strings in a given regex pattern;
assertRaises for expected exceptions.
The pipeline was applied in these suites:
Added assertion pipeline to example suite;
Added assertion pipeline to floresta-cli suite;
Added assertion pipeline to florestad suite.
Notes to the reviewers
This PR depends on #431 to work without false positives.
Checklist
just lintcargo test