Full rewrite with separate architechture and modular modules #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zh40Le1ZOOB
force-pushed
the
master
branch
2 times, most recently
from
8266c16 to
2fdb8b9
Compare
Owner
|
Thank you, I'll look into it after vacations. |
Author
|
|
Zh40Le1ZOOB
force-pushed
the
master
branch
2 times, most recently
from
d3913db to
1824b02
Compare
Author
Fixed! Everything works including overrideAttrs for any layer of args. |
Zh40Le1ZOOB
force-pushed
the
master
branch
3 times, most recently
from
01f26cd to
85a8f9c
Compare
Owner
|
@Zh40Le1ZOOB is this ready to be reviewed, or do you need to add anything else? |
Author
Ready, just some style fixup. No any other changes needed anymore. |
Author
|
I'm working on a much better rewrite of this now. Implementation part has completed, currently writing docs. |
Zh40Le1ZOOB
changed the title
Zh40Le1ZOOB
force-pushed
the
master
branch
2 times, most recently
from
e254b81 to
5b18968
Compare
Author
|
It's really ready this time, sry. |
Zh40Le1ZOOB
force-pushed
the
master
branch
2 times, most recently
from
22dcfc4 to
14a9e57
Compare
Author
|
@viperML Is there anyone going to review this? I'v been use it for a long time on my machine, it works very well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completely rewrote the wrapper-manager, this implemented separated build helper I came up in #16 (comment). Module system now has supported modular modules which is inspired by modular service, that means wrapper-manager has the same ability as home-manager on specific program configurations now. Users are able to write their own build helper and module with full
overrideAttrssupport. All build helpers are provided directly viaoverlays.default.Breaking changes:
envhas been renamed toenvVarsfor compatibilityflagsandwrapFlagshas been removed