Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(install): Add 'v' prefix when concatenating version to URL #1

Closed
wants to merge 3 commits into from

Conversation

orange-guo
Copy link

No description provided.

@virtualstaticvoid
Copy link
Owner

Hi @orange-guo

Thank you for your PR.

Unfortunately, the tests are failing, since the list command includes the leading "v" in the set of available versions, so running asdf install glooctl latest fails as there are now two v's in the download URL.

Could you please update the PR to change the list-all script, so that it removes the leading "v" from the list of available versions.

Thanks

@orange-guo
Copy link
Author

@virtualstaticvoid Sorry, I made a mistake, I should be making pr in this repository: https://github.com/halilkaya/asdf-glooctl.

@orange-guo
Copy link
Author

close pr

@orange-guo orange-guo closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants