Skip to content

Conversation

felixpalmer
Copy link
Collaborator

Fix needed for geoarrow/deck.gl-layers#133

Background

The HeatmapLayer does not currently work when data is passed in binary format (as needed by lonboard) as the buffer layout on the weights transform is not correct

Example to repro, included in this PR: 887aefe

Change List

  • Fix bug (by recreating weightsTransform whenever the data prop is changed
  • Remove use of setTexture2DData(...) as luma no longer allows this
  • Reinstate heatmap tests
  • Add new test to verify binary data buffer layouts are now correct

Copy link
Collaborator

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm not knowledgeable of HeatmapLayer internals, so I'm not the best reviewer, but I'm excited to see this in Lonboard

@coveralls
Copy link

Coverage Status

coverage: 91.113% (+0.009%) from 91.104%
when pulling de108ce on felix/heatmap-binary-attributes
into c3b8e28 on master.

@felixpalmer felixpalmer merged commit 3fd2bb5 into master Sep 24, 2025
5 checks passed
@felixpalmer felixpalmer deleted the felix/heatmap-binary-attributes branch September 24, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants