-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css): tree shake scoped styles #533
Merged
edison1105
merged 4 commits into
main
from
feat/pass-meta-vite-scoped-to-to-allow-scoped-styles-to-be-tresshaken
Mar 17, 2025
Merged
feat(css): tree shake scoped styles #533
edison1105
merged 4 commits into
main
from
feat/pass-meta-vite-scoped-to-to-allow-scoped-styles-to-be-tresshaken
Mar 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
45d9d2f
to
bb5b18f
Compare
…d-styles-to-be-tresshaken
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo
that referenced
this pull request
Mar 17, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@vitejs/plugin-vue](https://github.com/vitejs/vite-plugin-vue/tree/main/packages/plugin-vue#readme) ([source](https://github.com/vitejs/vite-plugin-vue/tree/HEAD/packages/plugin-vue)) | devDependencies | minor | [`5.1.5` -> `5.2.3`](https://renovatebot.com/diffs/npm/@vitejs%2fplugin-vue/5.1.5/5.2.3) | --- ### Release Notes <details> <summary>vitejs/vite-plugin-vue (@​vitejs/plugin-vue)</summary> ### [`v5.2.3`](https://github.com/vitejs/vite-plugin-vue/blob/HEAD/packages/plugin-vue/CHANGELOG.md#small523-2025-03-17-small) - Revert "fix: generate unique component id" ([#​548](vitejs/vite-plugin-vue#548)) ([4bc5517](vitejs/vite-plugin-vue@4bc5517)), closes [#​548](vitejs/vite-plugin-vue#548) ### [`v5.2.2`](https://github.com/vitejs/vite-plugin-vue/blob/HEAD/packages/plugin-vue/CHANGELOG.md#small522-2025-03-17-small) - feat: pass descriptor vapor flag to compileTemplte ([219e007](vitejs/vite-plugin-vue@219e007)) - feat(css): tree shake scoped styles ([#​533](vitejs/vite-plugin-vue#533)) ([333094f](vitejs/vite-plugin-vue@333094f)), closes [#​533](vitejs/vite-plugin-vue#533) - fix: generate unique component id ([#​538](vitejs/vite-plugin-vue#538)) ([2704e85](vitejs/vite-plugin-vue@2704e85)), closes [#​538](vitejs/vite-plugin-vue#538) - fix: properly interpret boolean values in `define` ([#​545](vitejs/vite-plugin-vue#545)) ([46d3d65](vitejs/vite-plugin-vue@46d3d65)), closes [#​545](vitejs/vite-plugin-vue#545) - fix(deps): update all non-major dependencies ([#​482](vitejs/vite-plugin-vue#482)) ([cdbae68](vitejs/vite-plugin-vue@cdbae68)), closes [#​482](vitejs/vite-plugin-vue#482) - fix(deps): update all non-major dependencies ([#​488](vitejs/vite-plugin-vue#488)) ([5d39582](vitejs/vite-plugin-vue@5d39582)), closes [#​488](vitejs/vite-plugin-vue#488) - fix(index): move the if check earlier to avoid creating unnecessary ssr when entering return block ( ([2135c84](vitejs/vite-plugin-vue@2135c84)), closes [#​523](vitejs/vite-plugin-vue#523) - fix(plugin-vue): default value for compile time flags ([#​495](vitejs/vite-plugin-vue#495)) ([ae9d948](vitejs/vite-plugin-vue@ae9d948)), closes [#​495](vitejs/vite-plugin-vue#495) - fix(plugin-vue): ensure HMR updates styles when SFC is treated as a type dependency ([#​541](vitejs/vite-plugin-vue#541)) ([4abe3be](vitejs/vite-plugin-vue@4abe3be)), closes [#​541](vitejs/vite-plugin-vue#541) - fix(plugin-vue): resolve sourcemap conflicts in build watch mode with cached modules ([#​505](vitejs/vite-plugin-vue#505)) ([906cebb](vitejs/vite-plugin-vue@906cebb)), closes [#​505](vitejs/vite-plugin-vue#505) - fix(plugin-vue): support external import URLs for monorepos ([#​524](vitejs/vite-plugin-vue#524)) ([cdd4922](vitejs/vite-plugin-vue@cdd4922)), closes [#​524](vitejs/vite-plugin-vue#524) - fix(plugin-vue): support vapor template-only component ([#​529](vitejs/vite-plugin-vue#529)) ([95be153](vitejs/vite-plugin-vue@95be153)), closes [#​529](vitejs/vite-plugin-vue#529) - fix(plugin-vue): suppress warnings for non-recognized pseudo selectors form lightningcss ([#​521](vitejs/vite-plugin-vue#521)) ([15c0eb0](vitejs/vite-plugin-vue@15c0eb0)), closes [#​521](vitejs/vite-plugin-vue#521) - chore(deps): update dependency rollup to ^4.27.4 ([#​479](vitejs/vite-plugin-vue#479)) ([428320d](vitejs/vite-plugin-vue@428320d)), closes [#​479](vitejs/vite-plugin-vue#479) - chore(deps): update dependency rollup to ^4.28.1 ([#​484](vitejs/vite-plugin-vue#484)) ([388403f](vitejs/vite-plugin-vue@388403f)), closes [#​484](vitejs/vite-plugin-vue#484) - chore(deps): update dependency rollup to ^4.29.1 ([#​493](vitejs/vite-plugin-vue#493)) ([b092bc8](vitejs/vite-plugin-vue@b092bc8)), closes [#​493](vitejs/vite-plugin-vue#493) - chore(deps): update upstream ([#​503](vitejs/vite-plugin-vue#503)) ([8c12b9f](vitejs/vite-plugin-vue@8c12b9f)), closes [#​503](vitejs/vite-plugin-vue#503) - chore(deps): update upstream ([#​511](vitejs/vite-plugin-vue#511)) ([d057351](vitejs/vite-plugin-vue@d057351)), closes [#​511](vitejs/vite-plugin-vue#511) - chore(deps): update upstream ([#​526](vitejs/vite-plugin-vue#526)) ([59946d3](vitejs/vite-plugin-vue@59946d3)), closes [#​526](vitejs/vite-plugin-vue#526) - chore(plugin-vue): simplify `resolved` declaration ([7288a59](vitejs/vite-plugin-vue@7288a59)) ### [`v5.2.1`](https://github.com/vitejs/vite-plugin-vue/blob/HEAD/packages/plugin-vue/CHANGELOG.md#small521-2024-11-26-small) - chore: add vite 6 peer dep ([#​481](vitejs/vite-plugin-vue#481)) ([4288652](vitejs/vite-plugin-vue@4288652)), closes [#​481](vitejs/vite-plugin-vue#481) - chore: fix lint ([378aea3](vitejs/vite-plugin-vue@378aea3)) - chore(deps): update dependency rollup to ^4.27.2 ([#​476](vitejs/vite-plugin-vue#476)) ([b2df95e](vitejs/vite-plugin-vue@b2df95e)), closes [#​476](vitejs/vite-plugin-vue#476) ### [`v5.2.0`](https://github.com/vitejs/vite-plugin-vue/blob/HEAD/packages/plugin-vue/CHANGELOG.md#520-2024-11-13) - feat: add a feature option to support custom component id generator ([#​461](vitejs/vite-plugin-vue#461)) ([7a1fc4c](vitejs/vite-plugin-vue@7a1fc4c)), closes [#​461](vitejs/vite-plugin-vue#461) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOTUuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIwNS4xIiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7248 Reviewed-by: Gusted <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the scoped styles in Vue generates styles scoped to that component, it can be tree shaken if that component is not used. (normal styles cannot be tree shaken as it can be used from other components).
This PR requires #526 and it uses a recently introduced feature in Vite (vitejs/vite#19418).
I tested this feature with https://vitepress.new/ and I got 8kB CSS file reduction.
Technically you can have a scoped style like below
and this would be treeshaken where you might not expect to. If we should handle this case, we can add an additional condition of
!code.includes(':global')
.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).