Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow resolving sourcemap when sources with query string uri #16192

Closed
wants to merge 1 commit into from

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Mar 18, 2024

Description

closes #16191

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Mar 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@userquin userquin marked this pull request as draft March 18, 2024 17:58
@userquin
Copy link
Contributor Author

userquin commented Mar 18, 2024

It seems the fix not working in vuetify reproduction (with latest Vite 5.1.6 and Nuxt 3.11.0), weird paths on my windows laptop (file: handled as relative path).

image

EDIT: sources with file:///....

image

@sapphi-red
Copy link
Member

Closing as I guess it's not needed anymore as the issue was fixed, but feel free to reopen or create a new one if it's still needed.

@sapphi-red sapphi-red closed this Sep 10, 2024
@userquin userquin deleted the fix-missing-soources branch September 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing sources when uri is not just a file
2 participants