feat/update-tests (#488)

* feat: init * chore: updated recommended * chore: update * chore(update): improve parser options * update * update * update * update * feat(tests): improve tests
vitest-dev · Aug 5, 2024 · 268df79 · 268df79
1 parent d4f2ff5
commit 268df79
Show file tree

Hide file tree

Showing 89 changed files with 292 additions and 250 deletions.
diff --git a/package.json b/package.json
@@ -22,7 +22,8 @@
 			"types": "./dist/index.d.ts",
 			"import": "./dist/index.mjs",
 			"require": "./dist/index.cjs"
-		}
+		},
+		"./package.json": "./package.json"
 	},
 	"files": [
 		"dist"

diff --git a/src/rules/consistent-test-filename.ts b/src/rules/consistent-test-filename.ts
@@ -19,7 +19,7 @@ export default createEslintRule<
   meta: {
     type: 'problem',
     docs: {
-      recommended: 'strict',
+      recommended: false,
       requiresTypeChecking: false,
       description: 'require .spec test file pattern'
     },

diff --git a/src/rules/consistent-test-it.ts b/src/rules/consistent-test-it.ts
@@ -56,7 +56,7 @@ export default createEslintRule<
     fixable: 'code',
     docs: {
       description: 'enforce using test or it but not both',
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       consistentMethod:

diff --git a/src/rules/expect-expect.ts b/src/rules/expect-expect.ts
@@ -38,7 +38,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     type: 'suggestion',
     docs: {
       description: 'enforce having expectation in test body',
-      recommended: 'strict'
+      recommended: false
     },
     schema: [
       {

diff --git a/src/rules/max-expects.ts b/src/rules/max-expects.ts
@@ -15,7 +15,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
   meta: {
     docs: {
       requiresTypeChecking: false,
-      recommended: 'strict',
+      recommended: false,
       description: 'enforce a maximum number of expect per test'
     },
     messages: {

diff --git a/src/rules/max-nested-describe.ts b/src/rules/max-nested-describe.ts
@@ -16,7 +16,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     docs: {
       description:
                 'require describe block to be less than set max value or default value',
-      recommended: 'strict'
+      recommended: false
     },
     schema: [
       {

diff --git a/src/rules/no-alias-methods.ts b/src/rules/no-alias-methods.ts
@@ -11,7 +11,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     docs: {
       description: 'disallow alias methods',
       requiresTypeChecking: false,
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       noAliasMethods: 'Replace {{ alias }}() with its canonical name {{ canonical }}()'

diff --git a/src/rules/no-commented-out-tests.ts b/src/rules/no-commented-out-tests.ts
@@ -15,7 +15,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
     docs: {
       description: 'disallow commented out tests',
       requiresTypeChecking: false,
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       noCommentedOutTests: 'Remove commented out tests. You may want to use `skip` or `only` instead.'

diff --git a/src/rules/no-conditional-expect.ts b/src/rules/no-conditional-expect.ts
@@ -19,7 +19,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     docs: {
       description: 'disallow conditional expects',
       requiresTypeChecking: false,
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       noConditionalExpect: 'Avoid calling `expect` inside conditional statements'

diff --git a/src/rules/no-conditional-in-test.ts b/src/rules/no-conditional-in-test.ts
@@ -11,7 +11,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
     docs: {
       description: 'disallow conditional tests',
       requiresTypeChecking: false,
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       noConditionalInTest: 'Remove conditional tests'

diff --git a/src/rules/no-conditional-tests.ts b/src/rules/no-conditional-tests.ts
@@ -10,7 +10,7 @@ export default createEslintRule<[], MESSAGE_ID>({
     type: 'problem',
     docs: {
       description: 'disallow conditional tests',
-      recommended: 'strict'
+      recommended: false
     },
     schema: [],
     messages: {

diff --git a/src/rules/no-disabled-tests.ts b/src/rules/no-disabled-tests.ts
@@ -11,7 +11,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     type: 'suggestion',
     docs: {
       description: 'disallow disabled tests',
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       missingFunction: 'Test is missing function argument',

diff --git a/src/rules/no-done-callback.ts b/src/rules/no-done-callback.ts
@@ -27,7 +27,7 @@ export default createEslintRule<Options, MessageIds>({
     type: 'suggestion',
     docs: {
       description: 'disallow using a callback in asynchronous tests and hooks',
-      recommended: 'strict'
+      recommended: false
     },
     deprecated: true,
     schema: [],

diff --git a/src/rules/no-duplicate-hooks.ts b/src/rules/no-duplicate-hooks.ts
@@ -9,7 +9,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
   name: RULE_NAME,
   meta: {
     docs: {
-      recommended: 'strict',
+      recommended: false,
       description: 'disallow duplicate hooks and teardown hooks',
       requiresTypeChecking: false
     },

diff --git a/src/rules/no-focused-tests.ts b/src/rules/no-focused-tests.ts
@@ -23,7 +23,7 @@ export default createEslintRule<Options, MessageIds>({
     type: 'problem',
     docs: {
       description: 'disallow focused tests',
-      recommended: 'strict'
+      recommended: false
     },
     fixable: 'code',
     schema: [
@@ -44,10 +44,7 @@ export default createEslintRule<Options, MessageIds>({
   },
   defaultOptions: [{ fixable: true }],
   create: (context) => {
-    const config = context.options[0] ?? {
-      fixable: true
-    }
-    const fixable = config.fixable
+    const fixable = context.options[0]?.fixable
 
     return {
       ExpressionStatement(node) {

diff --git a/src/rules/no-hooks.ts b/src/rules/no-hooks.ts
@@ -15,7 +15,7 @@ export default createEslintRule<
     type: 'suggestion',
     docs: {
       description: 'disallow setup and teardown hooks',
-      recommended: 'strict'
+      recommended: false
     },
     schema: [{
       type: 'object',

diff --git a/src/rules/no-identical-title.ts b/src/rules/no-identical-title.ts
@@ -21,7 +21,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     type: 'problem',
     docs: {
       description: 'disallow identical titles',
-      recommended: 'strict'
+      recommended: false
     },
     fixable: 'code',
     schema: [],

diff --git a/src/rules/no-import-node-test.ts b/src/rules/no-import-node-test.ts
@@ -9,7 +9,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
   meta: {
     docs: {
       description: 'disallow importing `node:test`',
-      recommended: 'strict'
+      recommended: false
     },
     type: 'suggestion',
     messages: {

diff --git a/src/rules/no-interpolation-in-snapshots.ts b/src/rules/no-interpolation-in-snapshots.ts
@@ -12,7 +12,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     type: 'problem',
     docs: {
       description: 'disallow string interpolation in snapshots',
-      recommended: 'strict'
+      recommended: false
     },
     fixable: 'code',
     schema: [],

diff --git a/src/rules/no-large-snapshots.ts b/src/rules/no-large-snapshots.ts
@@ -66,7 +66,7 @@ export default createEslintRule<[RuleOptions], MESSAGE_IDS>({
   meta: {
     docs: {
       description: 'disallow large snapshots',
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       noSnapShot: '`{{ lineCount }}`s should begin with lowercase',

diff --git a/src/rules/no-mocks-import.ts b/src/rules/no-mocks-import.ts
@@ -18,7 +18,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
     type: 'problem',
     docs: {
       description: 'disallow importing from __mocks__ directory',
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       noMocksImport: `Mocks should not be manually imported from a ${mocksDirName} directory. Instead use \`jest.mock\` and import from the original module path.`

diff --git a/src/rules/no-restricted-matchers.ts b/src/rules/no-restricted-matchers.ts
@@ -18,7 +18,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
   meta: {
     docs: {
       description: 'disallow the use of certain matchers',
-      recommended: 'strict'
+      recommended: false
     },
     type: 'suggestion',
     schema: [

diff --git a/src/rules/no-restricted-vi-methods.ts b/src/rules/no-restricted-vi-methods.ts
@@ -11,7 +11,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     type: 'suggestion',
     docs: {
       description: 'disallow specific `vi.` methods',
-      recommended: 'strict'
+      recommended: false
     },
     schema: [{
       type: 'object',

diff --git a/src/rules/no-standalone-expect.ts b/src/rules/no-standalone-expect.ts
@@ -40,7 +40,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
   meta: {
     docs: {
       description: 'disallow using `expect` outside of `it` or `test` blocks',
-      recommended: 'strict'
+      recommended: false
     },
     type: 'suggestion',
     messages: {

diff --git a/src/rules/no-test-prefixes.ts b/src/rules/no-test-prefixes.ts
@@ -11,7 +11,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
   meta: {
     docs: {
       description: 'disallow using `test` as a prefix',
-      recommended: 'strict'
+      recommended: false
     },
     type: 'suggestion',
     messages: {

diff --git a/src/rules/no-test-return-statement.ts b/src/rules/no-test-return-statement.ts
@@ -20,7 +20,7 @@ export default createEslintRule<Options, MessageIds>({
     type: 'problem',
     docs: {
       description: 'disallow return statements in tests',
-      recommended: 'strict'
+      recommended: false
     },
     schema: [],
     messages: {

diff --git a/src/rules/padding-around-after-all-blocks.ts b/src/rules/padding-around-after-all-blocks.ts
@@ -1,7 +1,7 @@
+import { getFilename } from "src/utils/msc"
 import { Config, PaddingType, StatementType, createPaddingRule } from "../utils/padding"
-import { URL } from "node:url"
 
-export const RULE_NAME = new URL('', import.meta.url).pathname
+export const RULE_NAME = getFilename(import.meta.url)
 
 export const config: Config[] = [
   {

diff --git a/src/rules/padding-around-after-each-blocks.ts b/src/rules/padding-around-after-each-blocks.ts
@@ -1,7 +1,7 @@
 import { Config, PaddingType, StatementType, createPaddingRule } from "../utils/padding";
-import { get_filename } from "../utils/msc";
+import { getFilename } from "../utils/msc";
 
-export const RULE_NAME = get_filename(import.meta.url)
+export const RULE_NAME = getFilename(import.meta.url)
 
 export const config: Config[] = [
   {

diff --git a/src/rules/padding-around-all.ts b/src/rules/padding-around-all.ts
@@ -7,9 +7,9 @@ import { config as paddingAroundDescribeBlocksConfig } from './padding-around-de
 import { config as paddingAroundExpectGroupsConfig } from './padding-around-expect-groups';
 import { config as paddingAroundTestBlocksConfig } from './padding-around-test-blocks';
 import { createPaddingRule } from '../utils/padding';
-import { get_filename } from '../utils/msc';
+import { getFilename } from '../utils/msc';
 
-export const RULE_NAME = get_filename(import.meta.url)
+export const RULE_NAME = getFilename(import.meta.url)
 
 export default createPaddingRule(
   RULE_NAME,

diff --git a/src/rules/padding-around-before-all-blocks.ts b/src/rules/padding-around-before-all-blocks.ts
@@ -1,7 +1,7 @@
-import { get_filename } from "../utils/msc";
+import { getFilename } from "../utils/msc";
 import { Config, PaddingType, StatementType, createPaddingRule } from "../utils/padding";
 
-export const RULE_NAME = get_filename(import.meta.url)
+export const RULE_NAME = getFilename(import.meta.url)
 
 export const config: Config[] = [
   {

diff --git a/src/rules/padding-around-before-each-blocks.ts b/src/rules/padding-around-before-each-blocks.ts
@@ -1,8 +1,7 @@
-
-import { get_filename } from '../utils/msc';
+import { getFilename } from '../utils/msc';
 import { PaddingType, StatementType, createPaddingRule } from '../utils/padding';
 
-export const RULE_NAME = get_filename(import.meta.url)
+export const RULE_NAME = getFilename(import.meta.url)
 
 export const config = [
   {

diff --git a/src/rules/padding-around-describe-blocks.ts b/src/rules/padding-around-describe-blocks.ts
@@ -1,8 +1,7 @@
-
-import { get_filename } from '../utils/msc';
+import { getFilename } from '../utils/msc';
 import { Config, PaddingType, StatementType, createPaddingRule } from '../utils/padding';
 
-export const RULE_NAME = get_filename(import.meta.url)
+export const RULE_NAME = getFilename(import.meta.url)
 
 export const config: Config[] = [
   {

diff --git a/src/rules/padding-around-expect-groups.ts b/src/rules/padding-around-expect-groups.ts
@@ -1,7 +1,7 @@
-import { get_filename } from "../utils/msc";
+import { getFilename } from "../utils/msc";
 import { Config, PaddingType, StatementType, createPaddingRule } from "../utils/padding";
 
-export const RULE_NAME = get_filename(import.meta.url)
+export const RULE_NAME = getFilename(import.meta.url)
 
 export const config: Config[] = [
   {

diff --git a/src/rules/padding-around-test-blocks.ts b/src/rules/padding-around-test-blocks.ts
@@ -1,8 +1,7 @@
-
-import { get_filename } from '../utils/msc';
+import { getFilename } from '../utils/msc';
 import { PaddingType, StatementType, createPaddingRule } from '../utils/padding';
 
-export const RULE_NAME = get_filename(import.meta.url)
+export const RULE_NAME = getFilename(import.meta.url)
 
 export const config = [
   {

diff --git a/src/rules/prefer-called-with.ts b/src/rules/prefer-called-with.ts
@@ -11,7 +11,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
     docs: {
       description:
         'enforce using `toBeCalledWith()` or `toHaveBeenCalledWith()`',
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       preferCalledWith: 'Prefer {{ matcherName }}With(/* expected args */)'

diff --git a/src/rules/prefer-comparison-matcher.ts b/src/rules/prefer-comparison-matcher.ts
@@ -53,7 +53,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
     type: 'suggestion',
     docs: {
       description: 'enforce using the built-in comparison matchers',
-      recommended: 'strict'
+      recommended: false
     },
     schema: [],
     fixable: 'code',

diff --git a/src/rules/prefer-each.ts b/src/rules/prefer-each.ts
@@ -11,7 +11,7 @@ export default createEslintRule({
     type: 'suggestion',
     docs: {
       description: 'enforce using `each` rather than manual loops',
-      recommended: 'strict'
+      recommended: false
     },
     schema: [],
     messages: {

diff --git a/src/rules/prefer-equality-matcher.ts b/src/rules/prefer-equality-matcher.ts
@@ -14,7 +14,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
     type: 'suggestion',
     docs: {
       description: 'enforce using the built-in quality matchers',
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       useEqualityMatcher: 'Prefer using one of the equality matchers instead',

diff --git a/src/rules/prefer-expect-assertions.ts b/src/rules/prefer-expect-assertions.ts
@@ -47,7 +47,7 @@ export default createEslintRule<Options[], MessageIds>({
   meta: {
     docs: {
       description: 'enforce using expect assertions instead of callbacks',
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       hasAssertionsTakesNoArguments:

diff --git a/src/rules/prefer-expect-resolves.ts b/src/rules/prefer-expect-resolves.ts
@@ -12,7 +12,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
     type: 'suggestion',
     docs: {
       description: 'enforce using `expect().resolves` over `expect(await ...)` syntax',
-      recommended: 'strict'
+      recommended: false
     },
     fixable: 'code',
     messages: {

diff --git a/src/rules/prefer-hooks-in-order.ts b/src/rules/prefer-hooks-in-order.ts
@@ -13,7 +13,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
     type: 'suggestion',
     docs: {
       description: 'enforce having hooks in consistent order',
-      recommended: 'strict'
+      recommended: false
     },
     messages: {
       reorderHooks: '`{{ currentHook }}` hooks should be before any `{{ previousHook }}` hooks'