fix(vite-node): fix when dumped module file name is greater than max file name #6447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the
test.server.debug
option (or the corresponding env var) and the module file path that is about to be dumped + the hash is greater than the file name max limit the dump fails (this is 255 chars in most systems)I did not add any test as currently there is no test on the debug functionality (did not find now and in the original PR #1723)
How did I fix it:
I just hashed twice using 2 different starting values for the djb hash function (use 2 to decrease the chance for hash collision as I suspect that the original path was part of the file name because of that)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.