Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor browser test utils #6624

Merged

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Oct 3, 2024

Description

Currently runBrowserTests utility is relying on json reporter output browser.json, which is causing a cryptic CI error in #6512. I rewrote this part to use assertions based on vitest state API.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fae3323
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66fe640c381c3400085097a8
😎 Deploy Preview https://deploy-preview-6624--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va
Copy link
Member

We use the json reporter to also indirectly test it. I think if you see cryptic errors, you can change the assertions themselves. Tests already print the stdout and stderr when failed.

@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Oct 3, 2024

We use the json reporter to also indirectly test it.

Yeah, if that's important, we can keep it for runner.test.ts, but I don't think we need to do it from runBrowserTests itself. I reverted the second commit and how does it look?

@sheremet-va
Copy link
Member

We use the json reporter to also indirectly test it.

Yeah, if that's important, we can keep it for runner.test.ts, but I don't think we need to do it from runBrowserTests itself. I reverted the second commit and how does it look?

Looks good to me 👍🏻

@hi-ogawa hi-ogawa marked this pull request as ready for review October 3, 2024 09:51
@sheremet-va sheremet-va merged commit 46be62c into vitest-dev:main Oct 3, 2024
17 checks passed
@hi-ogawa hi-ogawa deleted the test-refactor-browser-test-util branch October 3, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants